Skip to content

docs: point security reports at Bugcrowd in the PR template - #174

Merged
ryanio merged 1 commit into
mainfrom
chore/pr-template-comment
Aug 22, 2026
Merged

docs: point security reports at Bugcrowd in the PR template#174
ryanio merged 1 commit into
mainfrom
chore/pr-template-comment

Conversation

@ryanio

@ryanio ryanio commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The template already keeps its guidance inside HTML comments, so none of it leaks into contributor PR bodies. What it does not say is where to send a security report, and a vulnerability filed as a public pull request or issue is disclosed the moment it is opened.

Solution

One line added to the leading comment block, pointing at https://bugcrowd.com/engagements/opensea. Nothing else changes, and the rendered template is still just the Motivation and Solution headings.

Part of a sweep across the public OpenSea repos. The mirrored packages in opensea-devtools had the opposite problem: their template was plain markdown rather than a comment, so every community PR body opened with our own boilerplate. See opensea-sdk pull requests 1997 through 2000, all opened the same day, each beginning with "Thanks for opening a PR" before the author gets a word in.

Verified by stripping the HTML comments from the file and confirming the remainder is two headings and blank lines.

CI status

The four Forge jobs are red, and they were red before this branch existed. They fail in Install forge dependencies, before a single contract compiles:

Updating dependencies in /home/runner/work/<repo>/<repo>/lib
Error: git checkout exited with code 1: error: pathspec 'v1.5.0' did not match any file(s) known to git

.gitmodules pins lib/forge-std with branch = v1.5.0, but v1.5.0 is a tag upstream, not a branch, and the Foundry nightly these workflows install can no longer resolve it from its shallow clone. The tag itself still exists at foundry-rs/forge-std, so this is toolchain drift rather than a deleted ref.

Every Seaport Test CI and seadrop Test CI run going back months has failed the same way, including dependabot branches that change nothing but a lockfile. Seaport's own main at 08013390, the base of this branch, failed on 2025-09-30. The Hardhat jobs, linters, CodeQL and Socket all pass here.

A markdown file cannot affect forge install. Repinning forge-std or freezing the Foundry version belongs in its own PR, since it touches the toolchain for an audited contract repo.

Adds one line to the template's leading HTML comment so a contributor sees it
while writing the PR and does not file a vulnerability in public.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32599153900

Coverage decreased (-11.2%) to 53.427%

Details

  • Coverage decreased (-11.2%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 164 coverage regressions across 9 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

164 previously-covered lines in 9 files lost coverage.

File Lines Losing Coverage Coverage
src/clones/ERC721ACloneable.sol 62 0.0%
src/clones/ERC721SeaDropCloneable.sol 50 0.0%
src/clones/ERC721ContractMetadataCloneable.sol 15 0.0%
src/extensions/ERC721SeaDropPausable.sol 12 0.0%
src/clones/ERC721SeaDropCloneFactory.sol 9 0.0%
src/lib/ERC721TransferValidator.sol 5 0.0%
src/ERC721ContractMetadata.sol 4 91.03%
src/extensions/ERC721SeaDropSoulbound.sol 4 0.0%
src/test/MockTransferValidator.sol 3 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 789
Covered Lines: 413
Line Coverage: 52.34%
Relevant Branches: 422
Covered Branches: 234
Branch Coverage: 55.45%
Branches in Coverage %: Yes
Coverage Strength: 12.21 hits per line

💛 - Coveralls

@ryanio
ryanio merged commit fd6e01d into main Aug 22, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants