Repository navigation
Conversation
Add a regression test for the NibabelWriter path reported in Project-MONAI#9166. The underlying fix landed in Project-MONAI#9080, but the writer-level behavior was not covered directly. Assisted-by: Codex <noreply@openai.com> Signed-off-by: peng xiang <78131130+px12811@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Summary
Add a regression test for the public
NibabelWriterpath reported in #9166.The reported
TypeErroris already resolved ondevby the generalspatial_resamplefix in #9080. This PR adds direct coverage for the original writer-level scenario so the regression cannot return without failing this test.The new test writes a 2D channel-less array with
spatial_ndim=None,original_affine=None, and nospatial_shape, then verifies the saved data and affine.Validation
e28a2c07^, the new test fails with the reportedTypeError: '>=' not supported between instances of 'NoneType' and 'int'.dev, the new test passes.python -m pytest tests/data/test_nifti_rw.py -q: 42 passedpython -m pytest tests/transforms/test_spatial_resample.py -q: 76 passedpython -m pytest tests/data/test_image_rw.py -q: 2 passed, 28 skipped in the local minimal environmentruff,black --check,isort --check-only, andgit diff --check: passedAI disclosure
This contribution was prepared with Codex assistance and reviewed by the submitter, who will respond to review comments personally.