Repository navigation
Add a per-brand paper border and shadow toggle - #795
Merged
Merged
Conversation
Papers either have the fixed #D1D5DB border or none, and a shadow or none, per brand (design kit). Brands used to turn the border off by setting --prpl-color-border to transparent, which also hid chart axes, the current-month activity cell, task borders and other lines on that name. - New --prpl-color-border-paper (default: --prpl-color-border) for the paper border on widgets, the onboarding tasks box and the welcome wrapper. - The paper shadow is now built from --prpl-color-shadow-paper (7%, as before), so a brand can turn it off with transparent. - --prpl-color-field-shadow is its own #000, no longer tied to the paper shadow. Without a brand override nothing changes visually. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Test merged PR on Playground |
Contributor
✅ Code Coverage Report
🎉 Great job maintaining/improving code coverage! ℹ️ About this report
|
Contributor
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
232 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
377 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
381 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
388 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
📁 classes/suggested-tasks/data-collector/class-unpublished-content.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
103 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
📁 classes/activities/class-query.php (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
71 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58. |
163 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153. |
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
108 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106. |
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
120 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118. |
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
111 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the design kit, papers either have the fixed #D1D5DB border or none, and a shadow or none, per brand (confirmed by Mijke 2026-11-03). Zonnet and Gandi turned the border off by setting
--prpl-color-border: transparent, but Progress Planner uses that name for more than papers. On those brands the line chart's axes and grid lines, the current month's activity-score cell, the challenge background and the task/to-do/score borders would all disappear.What changes
--prpl-color-border-paper(defaultvar(--prpl-color-border)) for the paper border:.prpl-widget-wrapper,#prpl-onboarding-tasks,.prpl-wrap.prpl-pp-not-accepted. A brand sets it totransparentfor no border.--prpl-color-borderstays the fixed #D1D5DB.--prpl-color-shadow-paperat 7%, the same as the AI connector does, instead of a hard-codedrgba(0,0,0,0.07). A brand can turn it off withtransparent.--prpl-color-field-shadowis its own#000, so turning the paper shadow off doesn't affect fields.With no brand override, nothing changes visually.
Companion changes: AI connector (paper border reads the new name), your-branding (
tokens.json+ Zonnet).Testing
On planner.test, in Chrome:
rgb(209,213,219)1px, shadow 7% black, the same as before.rgb(209,213,219)and visible, current-month activity cell visible.--prpl-color-shadow-paper: transparentremoves the shadow.Pre-push checks passed: PHPStan, CSS/JS lint, token check.
🤖 Generated with Claude Code