Repository navigation
Revert the markdown recommendation experiment from develop - #787
Merged
Merged
Conversation
Contributor
|
Test merged PR on Playground |
Contributor
✅ Code Coverage Report
🎉 Great job maintaining/improving code coverage! ℹ️ About this report
|
Contributor
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
232 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
377 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
381 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
388 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
📁 classes/suggested-tasks/data-collector/class-unpublished-content.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
103 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
120 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118. |
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
111 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98. |
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
108 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106. |
📁 classes/activities/class-query.php (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
71 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58. |
163 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
Restores develop to the tree it had at 7c18816, immediately before a03361d was pushed to it on 2026-09-23. a03361d is a merge of origin/develop INTO filip/recommendation-format, made to bring that branch up to date. It was then pushed to develop rather than to the feature branch, which carried three days of prototype work onto the release branch by accident. Nothing shipped: the two classes this removes, Markdown_Recommendations and Markdown_Rule, have no references anywhere in the plugin. Nothing instantiates them and nothing hooks them to the provider filter, so they autoloaded and sat there. The 42 markdown files are data no code reads. The risk was packaging and review, not behaviour. Reverted with -m 2, so the mainline is old develop and only the material that arrived from the feature branch is removed. PR #777's sunset notice is untouched, and `git diff 7c18816` against this commit is empty. WHEN THE EXPERIMENT COMES BACK Merging filip/recommendation-format after this will bring back nothing: git treats those commits as merged and then reverted. Revert this commit first, or rebase the work onto a fresh branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ilicfilip
force-pushed
the
filip/revert-markdown-experiment
branch
from
September 23, 2026 13:45
e14e4bb to
a863ff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
developto the tree it had at7c18816f, immediately beforea03361dfwas pushed to it this morning.What happened
a03361dfis a merge oforigin/developintofilip/recommendation-format, made to bring that branch up to date. It was then pushed todevelopinstead of to the feature branch, which carried three days of prototype work onto the release branch by accident.The experiment is a format for goal-shaped recommendations written as markdown, intended for AI agents. It is unfinished and was never meant to leave its branch.
Release risk: none, but it should not be in the release
Markdown_RecommendationsandMarkdown_Rulehave no references anywhere in the plugin. Nothing instantiates them, nothing hooks them toprogress_planner_suggested_tasks_providers. They autoload and sit there. The 42 markdown files are data that no code reads.So nothing would have misbehaved — but 4,518 lines of prototype would have gone out in the package, and
phpcs.xml.distwould have shipped two loosened security rules that nobody reviewed.recommendations/*.md(42 files)classes/suggested-tasks/class-markdown-recommendations.phpclasses/suggested-tasks/providers/class-markdown-rule.phpbin/validate-recommendations.phpdocs/recommendation-format.md.github/workflows/recommendations.ymlcomposer.json,phpcs.xml.distVerification
Reverted with
-m 2, so the mainline is old develop and only material from the feature branch is removed.git diff 7c18816f <this commit>is empty — the tree is byte-identical to develop before the push-m 1revert would have deleted it; that was checked and rejectedWhen the experiment comes back
Merging
filip/recommendation-formatafter this will bring back nothing — git treats those commits as merged and then reverted. Revert this commit first, or rebase the work onto a fresh branch. The work is preserved atfilip/recommendation-format.