Skip to content

Revert the markdown recommendation experiment from develop - #787

Merged
ilicfilip merged 1 commit into
developfrom
filip/revert-markdown-experiment
Sep 23, 2026
Merged

ilicfilip merged 1 commit into
developfrom
filip/revert-markdown-experiment

Conversation

@ilicfilip

@ilicfilip ilicfilip commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Restores develop to the tree it had at 7c18816f, immediately before a03361df was pushed to it this morning.

What happened

a03361df is a merge of origin/develop into filip/recommendation-format, made to bring that branch up to date. It was then pushed to develop instead of to the feature branch, which carried three days of prototype work onto the release branch by accident.

The experiment is a format for goal-shaped recommendations written as markdown, intended for AI agents. It is unfinished and was never meant to leave its branch.

Release risk: none, but it should not be in the release

Markdown_Recommendations and Markdown_Rule have no references anywhere in the plugin. Nothing instantiates them, nothing hooks them to progress_planner_suggested_tasks_providers. They autoload and sit there. The 42 markdown files are data that no code reads.

So nothing would have misbehaved — but 4,518 lines of prototype would have gone out in the package, and phpcs.xml.dist would have shipped two loosened security rules that nobody reviewed.

Removed Lines
recommendations/*.md (42 files) 3,571
classes/suggested-tasks/class-markdown-recommendations.php 297
classes/suggested-tasks/providers/class-markdown-rule.php 180
bin/validate-recommendations.php 223
docs/recommendation-format.md 190
.github/workflows/recommendations.yml 41
composer.json, phpcs.xml.dist 16

Verification

Reverted with -m 2, so the mainline is old develop and only material from the feature branch is removed.

When the experiment comes back

Merging filip/recommendation-format after this will bring back nothing — git treats those commits as merged and then reverted. Revert this commit first, or rebase the work onto a fresh branch. The work is preserved at filip/recommendation-format.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Test merged PR on Playground
Test this pull request on the Playground
or download the zip

@github-actions

Copy link
Copy Markdown
Contributor

✅ Code Coverage Report

Metric Value
Total Coverage 34.27% 📉
Base Coverage 33.87%
Difference 📈 0.40%

⚠️ Coverage below recommended 40% threshold

🎉 Great job maintaining/improving code coverage!

ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
10 0 10

⚠️ Warnings (10)

📁 classes/suggested-tasks/providers/class-content-review.php (4 warnings)
📍 Line 🔖 Check 💬 Message
232 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
377 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
381 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
388 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/suggested-tasks/data-collector/class-unpublished-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
103 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
📍 Line 🔖 Check 💬 Message
120 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118.
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
111 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98.
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
📍 Line 🔖 Check 💬 Message
108 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106.
📁 classes/activities/class-query.php (2 warnings)
📍 Line 🔖 Check 💬 Message
71 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58.
163 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

Restores develop to the tree it had at 7c18816, immediately before
a03361d was pushed to it on 2026-09-23.

a03361d is a merge of origin/develop INTO filip/recommendation-format,
made to bring that branch up to date. It was then pushed to develop
rather than to the feature branch, which carried three days of prototype
work onto the release branch by accident.

Nothing shipped: the two classes this removes, Markdown_Recommendations
and Markdown_Rule, have no references anywhere in the plugin. Nothing
instantiates them and nothing hooks them to the provider filter, so they
autoloaded and sat there. The 42 markdown files are data no code reads.
The risk was packaging and review, not behaviour.

Reverted with -m 2, so the mainline is old develop and only the material
that arrived from the feature branch is removed. PR #777's sunset notice
is untouched, and `git diff 7c18816` against this commit is empty.

WHEN THE EXPERIMENT COMES BACK

Merging filip/recommendation-format after this will bring back nothing:
git treats those commits as merged and then reverted. Revert this commit
first, or rebase the work onto a fresh branch.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ilicfilip
ilicfilip force-pushed the filip/revert-markdown-experiment branch from e14e4bb to a863ff9 Compare September 23, 2026 13:45
@ilicfilip
ilicfilip merged commit 2b0bfc9 into develop Sep 23, 2026
22 checks passed
@ilicfilip
ilicfilip deleted the filip/revert-markdown-experiment branch September 23, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant