You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closing in favour of #776, which implements the same consolidation against current develop.
This branch had drifted ~2300 commits behind develop and conflicted in 6 of its 7 files. More importantly, it consolidates in the direction the codebase has since moved away from: it deletes Settings::get_post_types_names() and moves the implementation into Content_Helpers, but develop has since settled on Settings as the canonical home — that's where the newer suggested-task and data-collector classes call, and where the exclusion list has been maintained. Rebasing would have meant reverting that decision.
The underlying issue is still real, so #433 stays open until #776 merges. #776 goes the other way: it points the remaining Content_Helpers call sites at Settings and leaves Content_Helpers::get_post_types_names() as a deprecated shim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #433