Skip to content

Consolidate get_post_types_names() helper - #467

Closed
ilicfilip wants to merge 7 commits into
developfrom
filip/v15/consolidate-get-post-names
Closed

Consolidate get_post_types_names() helper#467
ilicfilip wants to merge 7 commits into
developfrom
filip/v15/consolidate-get-post-names

Conversation

@ilicfilip

Copy link
Copy Markdown
Collaborator

Implements #433

@github-actions

github-actions Bot commented May 5, 2025

Copy link
Copy Markdown
Contributor

Test on Playground
Test this pull request on the Playground or download the zip.

@ilicfilip ilicfilip added this to the 1.5.0 milestone May 6, 2025
@ilicfilip
ilicfilip marked this pull request as ready for review May 23, 2025 06:22
@ilicfilip ilicfilip removed this from the 1.5.0 milestone Sep 16, 2025
@ilicfilip

Copy link
Copy Markdown
Collaborator Author

Closing in favour of #776, which implements the same consolidation against current develop.

This branch had drifted ~2300 commits behind develop and conflicted in 6 of its 7 files. More importantly, it consolidates in the direction the codebase has since moved away from: it deletes Settings::get_post_types_names() and moves the implementation into Content_Helpers, but develop has since settled on Settings as the canonical home — that's where the newer suggested-task and data-collector classes call, and where the exclusion list has been maintained. Rebasing would have meant reverting that decision.

The underlying issue is still real, so #433 stays open until #776 merges. #776 goes the other way: it points the remaining Content_Helpers call sites at Settings and leaves Content_Helpers::get_post_types_names() as a deprecated shim.

@ilicfilip ilicfilip closed this Aug 25, 2026
@ilicfilip
ilicfilip deleted the filip/v15/consolidate-get-post-names branch August 25, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants