Disable goldmark unsafe HTML renderer#6
Closed
HeyItsGilbert wants to merge 1 commit into
Closed
Conversation
No content files use raw HTML that requires the unsafe renderer — the one exception (a 2008 podcast post with <p> and <br />) is converted to plain markdown. Disabling unsafe prevents raw HTML/JS in any markdown file from rendering, which limits the blast radius of future content injection vulnerabilities. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
This was merged in a previous PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markup.goldmark.renderer.unsafe: falseinhugo.yamlcontent/podcast/2008-03-16-one-liner-countdown-timer-in-powershell.md) to plain markdown — a<p>wrapper and four<br />line breaks, replaced with normal paragraph textWhy
With
unsafe: true, raw<script>,<iframe>, and other HTML tags in any.mdfile render verbatim in the browser. This amplifies the impact of any content injection vulnerability (e.g., the YAML frontmatter injection fixed in #5 — even after stripping HTML from the description field in the workflow, the setting remained a latent risk for any future external-input path that writes markdown).A full audit of all content files found no legitimate use of raw HTML requiring this setting. The
<>patterns in content are almost entirely Markdown autolinks (<https://...>) and plaintext angle brackets, which are unaffected by this change.Test plan
<p>/<br />🤖 Generated with Claude Code