fix(mcp): reset background capture after fork - #816
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-07-30 14:50:09 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
|
Reviews (1): Last reviewed commit: "fix(mcp): reset background capture after..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The MCP synchronous capture path can inherit background event-loop state across
fork(), but the daemon thread that drives that loop does not survive in the child. An inherited locked mutex or pending parent work can then deadlock or prevent later child captures from completing.Reset the MCP background capture loop, lock, and pending-work references in forked children without touching the parent's state or trying to close the defunct inherited loop.
💚 How did you test it?
/Users/marandaneto/Github/posthog-python/.venv/bin/python -m pytest posthog/test/mcp/test_instrumentation_fork.py -q/Users/marandaneto/Github/posthog-python/.venv/bin/ruff check posthog/mcp/_instrumentation.py posthog/test/mcp/test_instrumentation_fork.py/Users/marandaneto/Github/posthog-python/.venv/bin/ruff format --check posthog/mcp/_instrumentation.py posthog/test/mcp/test_instrumentation_fork.py/Users/marandaneto/Github/posthog-python/.venv/bin/python -W error -c "import posthog.mcp._instrumentation"git diff --check📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi implemented the targeted fix under human direction. Pi's autoreview report guided the final submission and found no actionable issues. The chosen approach uses
os.register_at_forkto replace only child-process background capture state, including the potentially locked mutex, while preserving parent-process behavior. A real-fork regression verifies that inherited work is cleared and a fresh child loop completes capture.