fix(client): reset registry lock after fork - #811
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-07-30 14:48:53 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
July 31, 2026 07:44
Contributor
|
Reviews (1): Last reviewed commit: "fix(client): reset registry lock after f..." | Re-trigger Greptile |
ioannisj
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
When a multithreaded process forks while the duplicate-client registry lock is held, the child inherits a permanently locked mutex whose owning thread no longer exists. Constructing or shutting down a client in the child can then deadlock.
This change detects a fork by PID and replaces the inherited registry lock once in each child while preserving inherited client bookkeeping.
💚 How did you test it?
/Users/marandaneto/Github/posthog-python/.venv/bin/python -m pytest posthog/test/test_client_fork.py posthog/test/test_client.py -q(161 passed)/Users/marandaneto/Github/posthog-python/.venv/bin/ruff check posthog/client.py posthog/test/test_client_fork.py/Users/marandaneto/Github/posthog-python/.venv/bin/ruff format --check posthog/client.py posthog/test/test_client_fork.pygit diff --checkfork(), verifies the child receives a replacement lock, and exercises child client registration and shutdown under a deadlock timeout.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
A human directed the fix and PR workflow. A Pi worker implemented and validated the targeted fork-safety change; Pi autoreview checked the patch and reported no actionable findings or blockers. The implementation preserves the inherited registry records and only replaces the lock once per child PID.