fix(capture): handle malformed before_send results - #810
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-07-30 14:48:18 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
July 31, 2026 07:46
Contributor
|
Reviews (1): Last reviewed commit: "fix(capture): handle malformed before_se..." | Re-trigger Greptile |
ioannisj
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
A malformed value returned by
before_sendcan make queued-event sizing raise in the background consumer. That exception can stop the consumer before acknowledging the queue item, preventing later valid events from being delivered and causing shutdown to hang.This change validates and re-cleans callback results before enqueueing. If an event still cannot be serialized for sizing, the consumer safely drops and acknowledges only that event without logging its payload, then continues processing the queue.
💚 How did you test it?
python -m pytest -q posthog/test/test_before_send.py posthog/test/test_consumer.py(37 passed)ruff format --check posthog/client.py posthog/consumer.py posthog/test/test_before_send.pyruff check posthog/client.py posthog/consumer.py posthog/test/test_before_send.pypython -W error -c "import posthog"git diff --check📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
A human directed the fix and remains the DRI. A Pi worker implemented the targeted changes and tests; Pi autoreview checked the resulting patch and reported no actionable findings. The implementation preserves the original-event fallback for callback errors while ensuring malformed queued items cannot terminate the consumer or leak payload contents into logs.