fix(capture): reject negative retry counts

[marandaneto]

💡 Motivation and Context

Negative capture retry counts previously skipped the upload loop entirely in direct consumer and capture v1 paths. Treating negative values as zero guarantees the initial delivery attempt while preserving existing behavior for zero and positive retry counts.

💚 How did you test it?

• Added regression tests for v0 and v1 capture in sync and async client modes.
• Added direct boundary tests for Consumer and capture v1 delivery.
• Ran the three focused test modules (271 tests passed).
• Ran Ruff format and lint checks on all changed Python files.
• Imported posthog with warnings treated as errors.

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• I updated the docs if needed.
• No breaking change or entry added to the changelog.

If releasing new changes

• Ran sampo add to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

A human directed the fix and PR preparation. Pi assisted with implementation and validation, and Pi autoreview checked the local patch with no actionable findings. The change clamps retries at the public client and defensive direct-call boundaries rather than altering retry-loop semantics.

[github-actions]

posthog-python Compliance Report

Date: 2026-07-30 16:48:50 UTC
Duration: 338361ms

✅ All Tests Passed!

111/111 tests passed

---

Capture_V1 Tests

✅ 94/94 tests passed

View Details

Test	Status	Duration
Endpoint And Method.Targets V1 Endpoint	✅	518ms
Endpoint And Method.Does Not Use Legacy Endpoints	✅	1009ms
Required Headers.Has Authorization Bearer Header	✅	1009ms
Required Headers.Has Content Type Json	✅	1009ms
Required Headers.Has Posthog Sdk Info Format	✅	1009ms
Required Headers.Has Posthog Attempt Header	✅	1008ms
Required Headers.Has Posthog Request Id	✅	1010ms
Required Headers.Has Posthog Request Timestamp	✅	1010ms
Required Headers.Has User Agent	✅	1009ms
Body Format.Body Has Created At And Batch	✅	1008ms
Body Format.No Api Key In Body	✅	1009ms
Body Format.No Sent At In Body	✅	1009ms
Event Format.Event Has Required Root Fields	✅	1009ms
Event Format.Event Uuid Is Valid	✅	1009ms
Event Format.Event Timestamp Is Rfc3339	✅	1009ms
Event Format.Distinct Id Is String	✅	1009ms
Event Format.Distinct Id At Root Not Properties	✅	1009ms
Event Format.Custom Properties Preserved	✅	1008ms
Event Format.Set Properties Preserved	✅	1009ms
Event Format.Set Once Properties Preserved	✅	1009ms
Event Format.Groups Properties Preserved	✅	1009ms
Event Format.Sdk Generates Uuid If Not Provided	✅	1009ms
Event Format.Event Has Required Root Fields Batch	✅	1012ms
Event Format.Event Uuid Is Valid Batch	✅	1014ms
Event Format.Event Timestamp Is Rfc3339 Batch	✅	1013ms
Event Format.Distinct Id Is String Batch	✅	1012ms
Event Format.Distinct Id At Root Not Properties Batch	✅	1013ms
Event Format.Custom Properties Preserved Batch	✅	1012ms
Event Format.Set Properties Preserved Batch	✅	1012ms
Event Format.Set Once Properties Preserved Batch	✅	1013ms
Event Format.Groups Properties Preserved Batch	✅	1013ms
Event Format.Sdk Generates Uuid If Not Provided Batch	✅	1012ms
Batch Behavior.Multiple Events In Single Batch	✅	1508ms
Batch Behavior.Batch Envelope Smoke	✅	1014ms
Batch Behavior.Flush With No Events Sends Nothing	✅	1004ms
Batch Behavior.Flush At Triggers Batch	✅	1508ms
Batch Behavior.Created At Reflects Batch Creation Time	✅	511ms
Deduplication.Generates Unique Uuids	✅	1508ms
Deduplication.Different Events Same Content Different Uuids	✅	1507ms
Deduplication.Preserves Uuid On Retry	✅	7515ms
Deduplication.Preserves Timestamp On Retry	✅	7512ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry	✅	7514ms
Deduplication.No Duplicate Events In Batch	✅	1504ms
Header Behavior On Retry.Attempt Header Starts At One	✅	1009ms
Header Behavior On Retry.Attempt Header Increments On Retry	✅	14524ms
Header Behavior On Retry.Request Id Preserved On Retry	✅	7504ms
Header Behavior On Retry.Different Requests Have Different Request Ids	✅	3520ms
Header Behavior On Retry.Request Timestamp Changes On Retry	✅	7514ms
Response Format Validation.Success Response Has Uuid Keyed Results	✅	1007ms
Response Format Validation.Success Response Has Ok For Each Event	✅	1507ms
Response Format Validation.Success No Retry After When All Ok	✅	1507ms
Response Format Validation.Success Retry After Present When Retry Events	✅	2510ms
Response Format Validation.Success No Retry After When Drop Only	✅	1507ms
Response Format Validation.Response Echoes Request Id	✅	1009ms
Retry Behavior.Retries On 408	✅	7511ms
Retry Behavior.Retries On 500	✅	7512ms
Retry Behavior.Retries On 503	✅	9519ms
Retry Behavior.Retries On 504	✅	7513ms
Retry Behavior.Retryable Errors Have Retry After	✅	4509ms
Retry Behavior.Respects Retry After On Retryable Error	✅	12517ms
Retry Behavior.Does Not Retry On 400	✅	3505ms
Retry Behavior.Does Not Retry On 401	✅	3507ms
Retry Behavior.Does Not Retry On 402	✅	3508ms
Retry Behavior.Does Not Retry On 413	✅	3508ms
Retry Behavior.Does Not Retry On 415	✅	3507ms
Retry Behavior.Non Retryable Errors Have No Retry After	✅	3507ms
Retry Behavior.Implements Backoff	✅	23522ms
Retry Behavior.Max Retries Respected	✅	23533ms
Partial Batch Handling.Handles 200 Full Success	✅	3001ms
Partial Batch Handling.Handles 200 With All Ok	✅	4511ms
Partial Batch Handling.Does Not Retry Dropped Events	✅	4508ms
Partial Batch Handling.Does Not Retry Limited Events	✅	4507ms
Partial Batch Handling.Prunes Ok Events On Partial Retry	✅	7515ms
Partial Batch Handling.Prunes Dropped Events On Partial Retry	✅	7514ms
Partial Batch Handling.Retries Only Retry Events From Partial	✅	7511ms
Partial Batch Handling.Partial Retry Preserves Uuids	✅	7510ms
Partial Batch Handling.Partial Retry Attempt Header Increments	✅	7516ms
Partial Batch Handling.Partial Retry Request Id Preserved	✅	7513ms
Partial Batch Handling.Respects Retry After On Partial	✅	9508ms
Partial Batch Handling.Unknown Result Treated As Terminal	✅	4511ms
Partial Batch Handling.Mixed Ok Drop Limited No Retry	✅	4507ms
Compression.Sends Gzip Content Encoding	✅	1010ms
Compression.No Content Encoding When Disabled	✅	1008ms
Compression.Compressed Body Is Decompressible	✅	1009ms
Error Handling.Does Not Retry On Unknown 4Xx	✅	3509ms
Event Options.Cookieless Mode Override	✅	1007ms
Event Options.Disable Skew Correction Override	✅	1009ms
Event Options.Process Person Profile Override	✅	1010ms
Event Options.Product Tour Id Override	✅	1007ms
Event Options.Unset Options Omitted	✅	1010ms
Event Options.Options Override In Batch	✅	1013ms
Geoip And Historical Migration.Geoip Disable Injected Into Properties	✅	1008ms
Geoip And Historical Migration.Historical Migration Set In Body	✅	1009ms
Geoip And Historical Migration.Historical Migration Absent By Default	✅	1009ms

Feature_Flags Tests

✅ 17/17 tests passed

View Details

Test	Status	Duration
Request Payload.Request With Person Properties Device Id	✅	1007ms
Request Payload.Flags Request Uses V2 Query Param	✅	1008ms
Request Payload.Flags Request Hits Flags Path Not Decide	✅	1006ms
Request Payload.Flags Request Omits Authorization Header	✅	1007ms
Request Payload.Token In Flags Body Matches Init	✅	1007ms
Request Payload.Groups Round Trip	✅	1007ms
Request Payload.Groups Default To Empty Object	✅	1006ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False	✅	1007ms
Request Payload.Disable Geoip Omitted Defaults To False	✅	1007ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key	✅	1007ms
Request Lifecycle.No Flags Request On Init Alone	✅	503ms
Request Lifecycle.No Flags Request On Normal Capture	✅	1507ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests	✅	1011ms
Request Lifecycle.Mock Response Value Is Returned To Caller	✅	1002ms
Retry Behavior.Retries Flags On 502	✅	1007ms
Retry Behavior.Retries Flags On 504	✅	1007ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event	✅	1509ms

[greptile-apps]

_{Reviews (1): Last reviewed commit: "fix: update public API snapshot" | Re-trigger Greptile}