fix(flags): align presence operator semantics - #234
Open
marandaneto wants to merge 1 commit into
Open
Conversation
Contributor
posthog-php Compliance ReportDate: 2026-08-26 07:49:34 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
August 26, 2026 10:00
|
Reviews (1): Last reviewed commit: "fix(flags): align presence operator sema..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
sdk-specs PR #49 defines
is_not_setusing partial property context. The PHP local evaluator returned an inconclusive exception even when the caller supplied the property key.This change returns false for
is_not_setwhenever the key is present, including null and other falsey values. An omitted key remains inconclusive.💚 How did you test it?
php -l lib/FeatureFlag.phpphp -l test/FeatureFlagLocalEvaluationTest.phpPHPUnit was not run locally because vendor dependencies were unavailable. CI will run the complete test suite.
📝 Checklist
If releasing new changes
pnpm changeto generate a change intent file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent worker subagents implemented the focused matcher change and regression tests. The bundled autoreview tool reviewed the final committed diff against
origin/main.