refactor: Share LLM response property construction - #188
Open
marandaneto wants to merge 1 commit into
Open
Conversation
Contributor
posthog-elixir Compliance ReportDate: 2026-08-22 12:21:38 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
|
Reviews (1): Last reviewed commit: "refactor: deduplicate LLM response prope..." | Re-trigger Greptile |
dustinbyrne
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The OpenAI Responses, OpenAI Chat Completions, Gemini, and Anthropic parsers each built the same core LLM analytics response properties. Keeping those maps separate makes it easy for the provider implementations to drift when the shared properties change.
This refactor moves the shared successful-response map into one private function. Each provider still owns its response matching, token extraction, and additional properties.
💚 How did you test it?
mix test test/posthog/integrations/llm_analytics/req_test.exsmix testmix credo --strictmix format --check-formatted lib/posthog/integrations/llm_analytics/req.ex📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent and Slopo were used to identify and refactor the duplicated response-property maps. The refactor was limited to successful response map construction because provider-specific parsing remains clearer in each response clause. Pi autoreview found no actionable issues in the final commit.