fix(ci): build the compliance adapter with the repo Gradle wrapper - #707
Merged
Conversation
The image-pinned gradle:9.6.1 skewed from the lockfiles regenerated under the 9.7.0 wrapper bump (#702): dependency locking pins the embedded Kotlin build-tools strictly per Gradle release, so the container's Gradle could no longer configure the plugin project. Building with ./gradlew keeps the two in lockstep permanently.
Contributor
|
Reviews (1): Last reviewed commit: "fix(ci): build the compliance adapter wi..." | Re-trigger Greptile |
dustinbyrne
approved these changes
Aug 18, 2026
cat-ph
enabled auto-merge (squash)
August 18, 2026 20:45
Contributor
posthog-android Compliance ReportDate: 2026-08-18 20:48:23 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SDK compliance job fails on every branch since #702 bumped the Gradle wrapper to 9.7.0. The adapter's Dockerfile pins its own Gradle (
FROM gradle:9.6.1-jdk17) and runs plaingradle, but the lockfiles are generated by the wrapper - and dependency locking pins the embedded Kotlin build-tools strictly per Gradle release (9.7.0 locks 2.4.0, the container's 9.6.1 requests 2.3.21). Configuration of the gradle-plugin project fails before any test runs.It slipped through because the compliance workflow's path filter (
posthog/**,sdk_compliance_adapter/**) never fires on wrapper or lockfile changes, so #702 merged without ever running the job.Changes
Build the adapter with the repo's own
./gradlewon a plain JDK image instead of an image-pinned Gradle. The container now always uses exactly the wrapper the lockfiles were generated with, so future wrapper bumps cannot skew it again.Tests
Local
docker build -f sdk_compliance_adapter/Dockerfile .of the exact CI invocation completes successfully (previously failed with the lock conflict). The compliance workflow also runs on this PR since it touchessdk_compliance_adapter/**.