test(server): add wire snapshots - #701
Open
dustinbyrne wants to merge 2 commits into
Open
Conversation
Contributor
|
dustinbyrne
marked this pull request as ready for review
August 17, 2026 21:29
dustinbyrne
marked this pull request as draft
August 17, 2026 21:29
Contributor
Prompt To Fix All With AI### Issue 1
posthog-server/src/test/java/com/posthog/server/PostHogServerWireSnapshotTest.kt:183
**Remove the unused mock response**
`createClient` enqueues a second response even though each isolated test sends and records exactly one request. This obscures the expected request count and suggests an initialization request that never occurs.
```suggestion
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "test(server): add wire snapshots" | Re-trigger Greptile |
dustinbyrne
marked this pull request as ready for review
August 17, 2026 21:33
Contributor
|
Reviews (2): Last reviewed commit: "test(server): remove unused mock respons..." | Re-trigger Greptile |
marandaneto
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Add deterministic wire-format snapshot coverage for the Java server SDK as part of the coordinated server-side SDK snapshot rollout. These tests make it easier to compare capture, identity, exception, safe-property, and feature-flag request payloads across SDK implementations and catch accidental serialization changes.
The snapshots cover the existing behavior only; this test-only change does not alter the published SDK or require a release entry.
💚 How did you test it?
./gradlew :posthog-server:test --tests "com.posthog.server.PostHogServerWireSnapshotTest"make checkFormat📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
This PR was prepared with the Pi coding agent (
worker). The human directed submission of the completed, independently reviewed server snapshot tests. The implementation keeps the change test-only and omits a changeset because it does not change released behavior. A human review is still required before merge.