Repository navigation
fix: report the discovery cache from the framework's cache manager - #26
Merged
Merged
Conversation
pollora_status looked for a cache key the framework stopped writing, so discovery_cached was always false. It now asks DiscoveryCacheManager, as pollora:doctor does.
ogorzalka
force-pushed
the
fix/discovery-cache-status
branch
from
October 13, 2026 17:18
cfbf640 to
4804053
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pollora_statusanswereddiscovery_cached: falseon every site: it checkedCache::has('pollora-discoverer-cache-discovery'), a key the framework no longer writes (scans are cached by Spatie's driver under thepolloraprefix, one entry per location).It now asks the framework's
DiscoveryCacheManager, aspollora:doctordoes:truewhen the persistent cache is on and holds every class on disk,falsein debug mode, when a location was never cached, or when a class added since is missing (whatdiscovery:clearfixes). Frameworks before 13.34, which have neither method, answerfalse.The old test asserted that the word
falseappeared somewhere in the response; the new ones cover each case, and the "cached" case fails on the previous code.Pest 81/81, PHPStan, Pint, Rector clean.