Repository navigation
feat: skills and guidelines for typed meta, roles and Block Bindings - #19
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap 2.5: Nectar catches up with framework v13.34.4 → v13.35.1.
pollora-typed-meta,pollora-roles,pollora-block-bindings, written from the documentation (meta.md, roles.md, block-bindings.md); every class and command name checked against the framework'sdevelopMetafacade, the new commands, whatpollora:doctornow checks^13.35, a short section on the three features, the request lifecycle (template_redirectafter boot, v13.35.1)^13.35, thetemplate_redirectchangeCanpermission; fix of the permission namespaces it taught (Pollora\\Attributes\\WpRestRoute\\Permissions\\IsAdminandPollora\\WpRest\\Domain\\Contracts\\Permissiondo not exist)#[Meta]and#[GrantsPostType]@cankept as text (Blade would compile it), point to the three skills, and every skill'snamematches its directoryPest 77 passed, Pint and PHPStan clean. (Rector flags 3 files that
mainalready has; CI does not run Rector.)