Repository navigation
A blank driver starts with templates: filter, shim settings, configuration values - #42
Merged
Merged
Conversation
…amples, configuration values Jerry: a driver made with the blank option lacked required elements, the filter for one. The blank driver now carries a starting filter (User and Group, the usual attributes synchronised both ways), shim settings with one example parameter in each section (driver, Subscriber, Publisher heartbeat interval) in the engine's definition form, and an empty configuration-values document, instead of an empty <filter/> and bare option groups. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Merged into master locally with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jerry: "when creating a new driver using the blank option there are some required elements. I think the filter for one. Blank should include a filter and a minimal config template."
driver.add --shim-class(the page's "a blank driver with a shim class") now writes, as templates to edit:Before, the blank driver had an empty
<filter/>and bare option groups.DriverOpsTest.blankDriverchecks the three documents; validation of the result stays clean.🤖 Generated with Claude Code