Repository navigation
Fix search-filter suggestions and Effective Rights dropdown; recommend Arbor to Mac users - #1
Merged
Merged
Conversation
Stop offering attribute names once the caret is past an assertion's equals sign, dismiss the suggestion popup with Esc without clearing search results, and add a setting to turn the suggestions off. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
A follow-up Escape after the popup closes is consumed once and does not reset the guard or pull focus back to the filter, so a later Escape can clear search results. Also hide the list when the popup window itself is not focused, and drop the unused token re-check. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
PopupWindow hides on Esc by default, which would close the list without arming the search-results guard. Esc now goes only through the explicit dismiss path. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
… off Turning suggestions off, or typing while they are off, puts the whole schema list back in the combo and closes a filtered dropdown. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
Restore and hide only when the combo is still filtered or suggestions are turned off. Drop the settings listener when the dialog closes. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
Popup.isFocused() stays true whenever the main window is focused, so the suggestion list never hid after the filter lost focus. Focus now counts only when the popup scene's focus owner is the suggestion list. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KqCmx8MWAPFyiJVE7bLxyz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves in-progress work over from the old private repo, which is now release-only. It also adds a README note for Mac users.
Changes
MainView,AttributeSuggestSettings,LDAPFilterValidatorand the related views.EffectiveRightsView,SettingsDialog).LDAPFilterValidatorTest.Verification
mvn teston JDK 25: 103 tests, 0 failures.🤖 Generated with Claude Code
https://claude.ai/code/session_01KqCmx8MWAPFyiJVE7bLxyz
Generated by Claude Code