Repository navigation
Add round-trip regression tests for _parse_ccsds_head - #70
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
_parse_ccsds_head_parse_ccsds_head
namurphy
commented
Oct 7, 2026
namurphy
commented
Oct 7, 2026
Member
Author
|
I read through these and the tests seemed sensible, though admittedly I don't have a full understanding of the functionality. Important These tests should be thought of as regression tests to make sure that changes to the code preserve existing behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
tests/decommutator/test_ccsds_reader_pipeline.pywith unit tests for_parse_ccsds_head. These are the first tests of an individual decommutator function; until now the decommutator was only tested end to end through the command line tool.A test helper,
_make_ccsds_head, packs header fields into 10 bytes withstruct.pack, independently of the code under test. The tests check that:0x7FF), all fields zero, and all fields at their maximum.ValueError.🤖 Generated with Claude Code