Repository navigation
Remove unused parameters and dead code from the decommutator - #67
Merged
Merged
Conversation
Remove unused verbose, ptp, and ccsds_head parameters from private helper functions, along with unreachable code after raise statements, unused variables, and commented-out code. Keep verbose on _cdf35e_35f so that main can call each CDF writer with the same arguments, and include the failing key in its RuntimeError message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up private helper functions in
src/pyfaradaycup/decommutator/.verbose,ptp, andccsds_head), along with their docstring entries and call site arguments.raisestatements, unused variables (npackets,scet_exp,foo), and commented-out code, including the old versioned skeleton file search in_get_newest_skeleton._cdf35e_35fnow includes the failing key in itsRuntimeErrormessage, instead of raising a bareRuntimeErrorfollowed by unreachable logging._cdf35e_35fkeeps itsverboseparameter, even though it is now unused, becausemaincalls each CDF writer withverbose=verbose. Without it, the resultingTypeErrorwould be caught by a bareexceptand only logged.filename = swp_spc_l02l1.pyinstead ofscriptname = swp_spc_l02l1.py.ruff:ignoresuppressions that no longer apply.🤖 Generated with Claude Code