Repository navigation
Make decommutator helper functions private - #66
Merged
Merged
Conversation
Prefix helper functions in the decommutator with an underscore and remove them from __all__. The functions that remain public are pfc_decommutator, swp_spc_l02l1.main, and the L0 file readers read_file and read_file_sc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefixes the helper functions in
src/pyfaradaycup/decommutator/with an underscore to mark them as private, and removes them from each module's__all__.These functions remain public:
main.pfc_decommutator: the command line toolswp_spc_l02l1.main: converts one L0 file into L1 CDF filesccsds_reader_pipeline.read_fileandread_file_sc: read an L0 file into Python data structuresThe
apid_objclass is unchanged.Now private:
ccsds_reader_pipeline:_read_stdin,_file2bytestr,_choose_file,_wrapper_status,_read_bytestr,_parse_ccsds_head,_parse_pkt,_get_layout,_get_layout_scswp_spc_l02l1:_cdf35e_35f,_cdf351_353_354,_cdf352,_secsubsec2scet,_statusmsg,_get_newest_kernel,_get_newest_skeletonCall sites, docstrings, and the decommutator
README.mdare updated to use the new names.🤖 Generated with Claude Code