Repository navigation
build: migrate standalone core to Bazel for v0.5.5 - #46
Merged
Merged
Conversation
Preserve concrete identity through typed output decoding and explicit of_type narrowing. Add abstract language and prompt matrix coverage plus CGS authoring guidance. Query/search and action outputs are supported; Get, relation-target sums and iteration outputs remain explicit follow-up work. Validated in the working tree: entity_union matrix 3 passed, constructor registry 4 passed, teaching matrix 1 passed, binding_contract 5 passed. Unrelated MCP work remains unstaged; its test fixture needed an unstaged pagination-state initializer to compile the host test suite. Two existing coverage-ledger omissions remain recorded separately.
Replace the vendored MCP SDK with rmcp for inbound and outbound HTTP, retain typed protocol failures and persistence, and move catalog publication into a host-independent crate. Update strict diagnostic consumers, protocol fixtures, release callers and the reviewed cutover documentation.
Record the task-oriented catalog mappings and documented GitHub integration coverage separately from core language and transport changes.
Box the SDK initialization error at its source, preserve typed causes and assert bounded protocol/transport/execution footprints. Release protocol-test locks before awaits and repair stale relation assertions and compiler hygiene.
There was a problem hiding this comment.
Stale comment
Documentation assessment (sync
287900f1)What the PR already does well
- Language ledger:
python-compute-contract.mddocuments execution-scopedPreparedCompute, numeric inference, and rejection evidence — aligned with runtime changes in this branch.- Constructors:
python-row-constructors.mdregistersof_type(BC-03); authoring reference covers closed nominal entity outputs.- Release notes:
CHANGELOG.mdandbuild/bazel/README.mdare strong single sources for the migration mechanics.- Authoring: Large
doc-site/docs/authoring/*refresh (input lanes, enum profiles, contract completeness) matches loader semantics.Gaps addressed on
cursor/system-documentation-quality-a25a(companion commit)
- Easter egg / maintenance: Bazel lived only in
build/bazel/README.mdwhile MkDocs,AGENTS.md, and rootREADMEstill read as cargo-only CI. Added Build and test and wired it through nav,getting-started,cli-and-env, andAGENTS.mdwithout duplicating patch lore.- Language definition drift:
plasm-language-definition.mddid not mention nominal entity unions or execution-scoped compute preparation although the compute contract and matrix did. Added short normative sections with links to authoring reference andPYTHON-COVERAGE.md.- Appliance inventory: CI section now points readers at Bazel nextest for the broader graph.
Remaining follow-ups (not blocking merge)
- Per-catalog READMEs under
apis/still mostly citecargo test; consider a one-line pointer to Build and test for maintainers, or leave as-is for catalog authors.python-compute-contract.md→ Audit verification block is a dated cargo-only snapshot; add a sentence that CI parity isbash build/bazel/bazel.sh test //:nextestwhen that section is next refreshed.- MkDocs strict: pre-existing broken relative link to
python-plasm-dag.txtin the language definition (use GitHub blob URL or vendor intodoc-site/).Recommend cherry-picking or merging the companion doc branch onto
codex/bazel-migrationbefore release so published docs andAGENTS.mdmatch v0.5.5 build expectations.Sent by Cursor Automation: Maintain docs
There was a problem hiding this comment.
Documentation assessment (automation)
Reviewed PR #46 against language-spec maintenance and user-facing docs holistically.
What already looks solid
- Language spec:
python-compute-contract.mdgains normative execution-scoped static preparation and an implementation ledger block for numeric inference / rejection evidence; wording matchesPreparedComputeScopeinplasm-agent-core. - Published links:
plasm-language-definition.mdnow uses absolute GitHub URLs for the teaching card andPYTHON-COVERAGE.md(fixes broken relative paths on GitHub Pages). - Packaging typo:
getting-started.mdcorrectly usesplasm-catalogforplasm-pack-catalogs. - Authoring sync:
skills/plasm-authoring→doc-site/docs/authoringprojection checks clean. - Deep Bazel reference:
build/bazel/README.mdis thorough for maintainers.
Gaps addressed on branch cursor/system-documentation-quality-7857 → PR #48 (targets this branch)
| Antipattern | Issue | Remedy |
|---|---|---|
| Assumption gap | CHANGELOG / Bazel graph ship while README + Start here still read as cargo-only | New doc-site/docs/reference/building-from-source.md + README / AGENTS / getting-started cross-links |
| Easter egg hunt | Normative python-compute-contract.md et al. not in MkDocs nav; docs/mcp-*.md orphaned from any index |
MkDocs Language nav expanded; docs/README.md indexes internal notes |
| Maintenance nightmare | (avoided) | Bazel commands stay canonical in build/bazel/README.md; public page only summarizes |
Remaining nits (non-blocking)
- Constructor registries (
python-*-constructors.md) remain intentionally off-nav; hub isplasm-language-definition.md. Consider a single “Constructor registries” nav group later if onboarding feedback says otherwise. cli-and-env.mdcould note discontinued Intel macOS release artifacts (CHANGELOG already states this).- Matrix ledger: new inference witnesses are documented in the compute contract ledger; keep CI nextest registration aligned as the Bazel suite expands (per
build/bazel/README.md).
Please merge or cherry-pick PR #48 once convenient.
Sent by Cursor Automation: Maintain docs
ryan-s-roberts
marked this pull request as ready for review
October 20, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Core now builds independently through a pinned Bazel graph, and SaaS consumes the same targets as an external module. Rust suites use nextest; release archives and npm packages consume declared build outputs. The published Monty fork is pinned and typeshed archives are deterministic.
Release platforms are macOS Apple Silicon and Linux x86-64 GNU. Intel macOS artifacts are removed. Compiler selection isolates Bazel from login-shell compiler-cache wrappers while preserving macOS SDK discovery.
Validation:
docs/bazel-migration.md.bash build/bazel/bazel.sh build //:catalogs --jobs=2.test,e2e,argocd_native_amd64) on SaaS commit6b40bea5e7; Phoenix passed 200 hosted and 71 shared UI tests, and both appliance gates passed. Later changes are release preparation and documentation, which will be revalidated by main CI before tagging.Prepares v0.5.5 release notes. Merge core before the parent SaaS migration.