feat(place/driver_health): include driver processes running on edges - #628
Merged
Conversation
) A core node already reports the processes on each edge attached to it, in the same responses we were making, but only the `local` half was being read. So a driver running only on an edge was invisible, and one running on both a node and an edge was reported for the node alone. Now the union of `loaded.local` and every `loaded.edge` entry is walked, and a state is emitted per location a driver runs in, taking memory from `status.local` or `status.edge[edge_id]` as appropriate. This costs no extra requests, a single driver status response covers the node and all of its edges. Edge processes are named `<edge id>.<driver>`. Edges aren't queried directly and the node an edge happens to be attached to isn't part of the path to it, so neither the edge hostname nor the core hostname belongs in the name. Results are deduplicated by name, so an edge reported by more than one core node is counted once. Not yet exercised against a live edge, the spec covers it with fake core nodes. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A core node already reports the processes on each edge attached to it, in the same responses we were making, but only the
localhalf was being read. So a driver running only on an edge was invisible, and one running on both a node and an edge was reported for the node alone.Now the union of
loaded.localand everyloaded.edgeentry is walked, and a state is emitted per location a driver runs in, taking memory fromstatus.localorstatus.edge[edge_id]as appropriate. This costs no extra requests, a single driver status response covers the node and all of its edges.Edge processes are named
<edge id>.<driver>. Edges aren't queried directly and the node an edge happens to be attached to isn't part of the path to it, so neither the edge hostname nor the core hostname belongs in the name. Results are deduplicated by name, so an edge reported by more than one core node is counted once.