Expand neighbors in place instead of re-laying out and re-fitting the whole graph - #39
Merged
Merged
Conversation
… whole graph Double-click expansion ran a full-graph layout with fit enabled and then animated a second fit to the neighborhood, so every existing node moved and the camera jumped. Expansion now preserves the viewport and all existing positions and seeds the new neighbors in a ring around the expanded node; Fit, Reset, and mode switches keep their whole-graph behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Local embedding tests downloaded a real model during unit runs and flaked with the runner's network; they are now opt-in with a printed skip reason, and the release lane's cold-local job keeps enforcing the real download. The workspace persistence test rendered the full shell near the default timeout under contention; it is faster now and carries explicit headroom along with the other full-shell renders. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in real use: double-clicking a node to expand its neighbors made the whole graph jump. The expansion callback ran a full-graph layout with fit enabled and then animated a second fit to the neighborhood, so every existing node moved and the camera relocated.
Expansion is now incremental by contract: the planner returns preserveViewport with no layout and no fit, the viewport is captured before the neighbor request, existing positions are untouched, and new neighbors are seeded in a deterministic ring around the expanded node. Fit, Reset view, and mode switches keep their whole-graph behavior because those genuinely change the picture.
Verification: red-first planner tests (no fit, no global layout, ring seeds relative to the source), dashboard suite 88/88, vite build and pnpm turbo build 21/21.
🤖 Generated with Claude Code