Skip to content

Money switch building active animation - #2380

Open
dh381-1 wants to merge 66 commits into
Phobos-developers:developfrom
dh381-1:MoneyChangeAnimation
Open

Money switch building active animation#2380
dh381-1 wants to merge 66 commits into
Phobos-developers:developfrom
dh381-1:MoneyChangeAnimation

Conversation

@dh381-1

@dh381-1 dh381-1 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

  • Now you can use ActiveAnim.MoneyAmount, ActiveAnimTwo.MoneyAmount, ActiveAnimThree.MoneyAmount, ActiveAnimFour.MoneyAmount to switch active animation of building.
  • When funds are greater than ActiveAnimFour.MoneyAmount, ActiveAnimFour is played; when funds are greater than ActiveAnimThree.MoneyAmount but less than ActiveAnimFour.MoneyAmount, ActiveAnimThree is played, and so on. If the corresponding animation does not exist, no switch will occur.

In rulesmd.ini:

[SOMEBUILDING]                   ; BuildingType
ActiveAnim.MoneyAmount=1000      ; integar
ActiveAnimTwo.MoneyAmount=2000   ; integar
ActiveAnimThree.MoneyAmount=3000 ; integar
ActiveAnimFour.MoneyAmount=4000  ; integar
All four configuration entries default to `-1`. The feature will only be enabled when all entries have been configured.

dh381-1 added 22 commits August 23, 2026 11:48
@dh381-1
Merge upstream/develop and resolve conflicts
4fb6212
@dh381-1
add IvanBomb.Detonate gif
9b78f6e
@dh381-1
add IvanBomb.Detonate
a7a4f38
@dh381-1
Update New-or-Enhanced-Logics.md
6ca4890
@dh381-1
Update Body.h
c32e59d
@dh381-1
Update CREDITS.md
1f7c416
@dh381-1
1
0465718
@dh381-1
update Hooks.WeaponEfects.cpp
a3af3cf
@dh381-1
update Hooks.WeaponEffects.cpp
2ce9c38
@dh381-1
update Hooks.WeaponEffect.cpp
66dbf2e
@dh381-1
fix bug
2744e97
@dh381-1
Update New-or-Enhanced-Logics.md
872ee5b
@dh381-1
add new IvanBomb detonate logic
73e83d9
@dh381-1
Merge branch 'develop' of https://github.com/dh381-1/Phobos into develop
167ed8f
@dh381-1
Update New-or-Enhanced-Logics.md
95b9353
@dh381-1
Update New-or-Enhanced-Logics.md
daf1947
@dh381-1
update Detonate.cpp
a5ff103
@dh381-1
Merge branch 'develop' of https://github.com/dh381-1/Phobos into develop
ec9a9c9
@dh381-1
add IvanBomb.Detonate.PenetrateTransport and IvanBomb.Detonate.Penetr…
bc2f561 
…ateBuilding
@dh381-1
initial
bee9de1
@dh381-1
update doc
01787f5
@dh381-1
update doc
721c86c
NetsuNegi
NetsuNegi reviewed Aug 31, 2026
View reviewed changes
Comment thread docs/New-or-Enhanced-Logics.md Outdated
NetsuNegi
NetsuNegi reviewed Aug 31, 2026
View reviewed changes
Comment thread CREDITS.md Outdated
@github-actions

github-actions Bot commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

NetsuNegi
NetsuNegi requested changes Aug 31, 2026
View reviewed changes
Comment thread src/Ext/Building/Hooks.cpp Outdated
Comment thread src/Ext/Building/Hooks.cpp Outdated
Comment thread src/Ext/Building/Hooks.cpp Outdated
Comment thread src/Ext/Building/Hooks.cpp Outdated
Comment thread src/Ext/Building/Hooks.cpp Outdated
Comment thread src/Ext/Building/Hooks.cpp Outdated
Comment thread src/Ext/Building/Hooks.cpp Outdated
&& pTypeExt->ActiveAnimThree_MoneyAmount != -1
&& pTypeExt->ActiveAnimFour_MoneyAmount != -1)
{
if(auto pBuildingExt = BuildingExt::Fetch(pThis))

@NetsuNegi NetsuNegi Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Comment thread src/Ext/Building/Hooks.cpp Outdated
&& pTypeExt->ActiveAnimThree_MoneyAmount != -1
&& pTypeExt->ActiveAnimFour_MoneyAmount != -1)
{
if(auto pBuildingExt = BuildingExt::Fetch(pThis))

@NetsuNegi NetsuNegi Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Comment thread src/Ext/Building/Hooks.cpp Outdated
{
int Grade = pBuildingExt->MoneyGrade;
R->EAX(Grade);
__asm { cmp eax, 3 }

@NetsuNegi NetsuNegi Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should manually compare and jump to the corresponding address instead of directly writing the assembly.
你应当手动检查并跳转到对应地址，而不是直接写汇编。

Comment thread src/Ext/Building/Hooks.cpp Outdated
__asm
{
cmp eax, 3
mov [esi + 0x6F0], eax

@NetsuNegi NetsuNegi Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.
这里也是。

@phoboscn-bot

phoboscn-bot commented Sep 1, 2026

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/755/1

@NetsuNegi NetsuNegi added the ❓Unhardcoding / Customization Make something more tweakable label Sep 9, 2026
@DeathFishAtEase DeathFishAtEase added ❓New feature and removed ❓Unhardcoding / Customization Make something more tweakable labels Sep 12, 2026
DeathFishAtEase and others added 21 commits September 12, 2026 15:25
@DeathFishAtEase
fix Changelog & CREDITS
d770b0c
@DeathFishAtEase
Merge remote-tracking branch 'Phobos-developers/develop' into MoneyCh…
15366a5 
…angeAnimation
@dh381-1
update code and doc
47e038f
@dh381-1
update name
0e3b1c5
@DeathFishAtEase
update docs
4782ae4
@DeathFishAtEase
[doc] remove redundant blank lines
9b2b1a8
@DeathFishAtEase
[doc] remove outdated descriptions
9594c92
@Coronia
Merge branch 'develop' into develop
a5c4c1f
@dh381-1
update
35ea4b5
@dh381-1
Merge branch 'develop' of https://github.com/dh381-1/Phobos into develop
3dde927
@NetsuNegi
Update Detonate.cpp
2175916
@Coronia
optimize
47a2f3c
@Coronia
rename
6fd3243
@DeathFishAtEase
→
0924003
@Coronia
typo
6282f92
@Coronia
only check Owner when SameInvokerOnly set to true
7f85ec9
@dh381-1
Merge branch 'develop' into MoneyChangeAnimation
0e0ae6f
@NetsuNegi
Merge branch 'develop' into MoneyChangeAnimation
79e4783
@dh381-1
Merge branch 'develop' into MoneyChangeAnimation
6251fe2
@dh381-1
Merge branch 'develop' of https://github.com/dh381-1/Phobos into Mone…
23f51e8 
…yChangeAnimation
@dh381-1
resolve conflict
8dc5fa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NetsuNegi NetsuNegi NetsuNegi requested changes
@TaranDahl TaranDahl Awaiting requested review from TaranDahl

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Needs testing ❓New feature ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dh381-1 @phoboscn-bot @TaranDahl @NetsuNegi @Coronia @DeathFishAtEase