style: cargo fmt after #7747 and bump to 0.5.1437 - #7750
Merged
Conversation
The fork PR was squash-merged from its own head, so the rebase's fmt fix and version bump did not land with it. main was red on `cargo fmt --check`. Claude-Session: https://claude.ai/code/session_01Y1QZ5wUP9gRSwpiweT4Wix
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe workspace and documented versions were updated from ChangesRelease metadata and formatting
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainwent red oncargo fmt --checkafter #7747. That PR came from a fork, and GitHub squash-merged the fork's own head — so thecargo fmtfix and version bump I made while rebasing it locally never landed.Two files:
gc/tests/buffer_bound_method_name.rsandobject/field_get_set/get_field_by_name_tail.rs. Plus the missed bump, 0.5.1436 → 0.5.1437.Worth noting for future fork PRs: rebasing locally and gating is not enough — the merge takes the fork's head, so anything fixed only in the local rebase is silently dropped. Either push the fixes to the fork branch, or land them as a follow-up like this one.
Summary by CodeRabbit
Chores
Style