Skip to content

style: cargo fmt after #7747 and bump to 0.5.1437 - #7750

Merged
proggeramlug merged 1 commit into
mainfrom
fix/7747-fmt-and-bump
Aug 10, 2026
Merged

style: cargo fmt after #7747 and bump to 0.5.1437#7750
proggeramlug merged 1 commit into
mainfrom
fix/7747-fmt-and-bump

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

main went red on cargo fmt --check after #7747. That PR came from a fork, and GitHub squash-merged the fork's own head — so the cargo fmt fix and version bump I made while rebasing it locally never landed.

Two files: gc/tests/buffer_bound_method_name.rs and object/field_get_set/get_field_by_name_tail.rs. Plus the missed bump, 0.5.1436 → 0.5.1437.

Worth noting for future fork PRs: rebasing locally and gating is not enough — the merge takes the fork's head, so anything fixed only in the local rebase is silently dropped. Either push the fixes to the fork branch, or land them as a follow-up like this one.

Summary by CodeRabbit

  • Chores

    • Incremented the workspace version to 0.5.1437.
    • Updated the documented current version.
  • Style

    • Reformatted internal code for improved consistency and readability without changing behavior.

The fork PR was squash-merged from its own head, so the rebase's fmt fix
and version bump did not land with it. main was red on `cargo fmt --check`.

Claude-Session: https://claude.ai/code/session_01Y1QZ5wUP9gRSwpiweT4Wix
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 352059dc-28f6-4132-afe9-7f6545e8875d

📥 Commits

Reviewing files that changed from the base of the PR and between 55bf8d8 and 2a53aea.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • CLAUDE.md
  • Cargo.toml
  • crates/perry-runtime/src/gc/tests/buffer_bound_method_name.rs
  • crates/perry-runtime/src/object/field_get_set/get_field_by_name_tail.rs

📝 Walkthrough

Walkthrough

The workspace and documented versions were updated from 0.5.1436 to 0.5.1437. Several Buffer-related Rust statements were reformatted without observable behavior or API changes.

Changes

Release metadata and formatting

Layer / File(s) Summary
Version metadata and Rust formatting
CLAUDE.md, Cargo.toml, crates/perry-runtime/src/gc/tests/buffer_bound_method_name.rs, crates/perry-runtime/src/object/field_get_set/get_field_by_name_tail.rs
Version references now use 0.5.1437. Buffer-related statements were reformatted without behavior changes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: jdalton, thehypnoo

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change but omits the required Summary, Changes, Related issue, Test plan, Screenshots/output, and Checklist sections. Use the repository template and add the required sections, including test results, related issue status, checklist responses, and the reason for the prohibited metadata changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the formatting fix after #7747 and the version bump to 0.5.1437.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/7747-fmt-and-bump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit 24031bf into main Aug 10, 2026
27 of 50 checks passed
@proggeramlug
proggeramlug deleted the fix/7747-fmt-and-bump branch August 10, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant