Preserve sources of resistances granted to minions - #10350
Open
AdamZ-8113 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10241
Description of the problem being solved:
Bonemeld's added minion resistances show as coming from
Playerin Calcs, with a blank Source Name.This is because the calculation discards the original modifier source when creating the minion resistance bonuses. This preserves each contributing source so Calcs can show its name and the existing item tooltip.
Each contribution is now rounded down separately. A single source like Bonemeld will be accurate, but multiple sharing modifiers can produce slightly different totals: two 50% contributions from 75% player resistance give 37 + 37 = 74 instead of 75. The alternative solution would be to combine sources back to a generic
Playerto prevent small rounding errors.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pob.codes/b/mpx-NPDYaIq
Before screenshot:
After screenshot: