Show timeless passive source names in Calcs - #10349
Open
AdamZ-8113 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10247
Description of the problem being solved:
Tempered by War doesn't show its name in Calcs for its resistance penalties or damage taken conversions.
This is because the source lookup only handles numbered tree nodes and tattoos, and cuts off textual IDs at underscores. This adds support for complete textual IDs and looks up timeless passive names when no tattoo matches. Existing tattoo support is preserved.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/kOXu-99xHr7w (from the issue)
Before screenshot:
After screenshot: