Add private leagues back into trader - #10212
Draft
vaisest wants to merge 2 commits into
Draft
Conversation
|
For what it's worth, I pulled your branch down and did a test run and was able to see my private league |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10211
Description of the problem being solved:
Private leagues were removed from the trader with the removal of POESESSID. However, we do have the
account:leaguesscope, which means we can use the matching OAuth endpoint to fetch the leagues.This also fixes an issue where the "Search for" button only ever opens the PC site, since I noticed that just now. (Thankfully nobody plays on console).
Steps taken to verify a working solution:
Sadly I'm not actually in any private leagues, so while it does clearly fetch the leagues
Link to a build that showcases this PR:
Before screenshot:
After screenshot: