Skip to content

Fix Pounce support socket counting#1924

Closed
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/pounce-support-socket-count
Closed

Fix Pounce support socket counting#1924
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/pounce-support-socket-count

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Summary

Fixes #1672

Stop active-skill internal support effects from being counted as socketed support gems when validating the five-support socket limit.

Root Cause

Pounce is an active skill gem that also exports an internal support effect. During setup, socket-limit validation counted any gem instance with supportEffect, so Pounce itself was counted as one support before the five actual socketed supports were counted. A legal Pounce setup with five support gems therefore appeared to have six supports and produced the "too many gems" warning.

Fix

  • Count only gem instances whose own granted effect is a support gem when calculating socketed support-gem totals.
  • Use that same socketed support effect for red/green/blue support requirement counters.
  • Add a regression covering Pounce with five socketed supports and a control case with six actual socketed supports.

Validation

  • gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state all --search "#1672" --json number,title,state,url,headRefName,author --limit 20 -> []
  • gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state all --search "Pounce too many gems" --json number,title,state,url,headRefName,author --limit 20 -> []
  • gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state all --search "support gems socket limit" --json number,title,state,url,headRefName,author --limit 20 -> []
  • git diff --check -> passed
  • git diff --cached --check -> passed
  • git show --check --oneline --no-renames HEAD -> passed
  • Lua syntax check with Python/Lupa for spec/System/TestSkills_spec.lua -> passed
  • Lua syntax check with Python/Lupa for src/Modules/CalcSetup.lua -> blocked by a pre-existing upstream Lupa parse failure at line 970 (attempt to assign to const variable 'slot'); confirmed the same failure on upstream/dev before this change.
  • lua, luajit, busted, docker, and docker-compose are not installed on this Windows PATH, so I could not run the Busted suite locally.

Risk / Rollback

Risk is limited to socketed support-gem counting and support-color requirement totals. Item-granted/internal support effects should not consume sockets, while actual support gems still do. Rollback is the single commit on this branch.

@LocalIdentity
Copy link
Copy Markdown
Contributor

Not needed anymore. Overcomplicated fix and handled by 4ec71b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pounce skill - "too many gems"

2 participants