Use totem actor level for totem life#1918
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Not a problem anymore and the totem uses the players weapon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #261
Use the totem skill's exported actor level when calculating totem level/life, with the previous minion-gem-level table kept as the fallback for totem sources that do not export an actor level.
Root Cause
Totem life is calculated from
monsterAllyLifeTable[skillData.totemLevel], butskillData.totemLevelwas always derived fromdata.minionLevelTable[gemLevel].For Shockwave Totem, the exported skill stat set gives level 20 an actor level of about 97.7. The minion level table maps gem level 20 to level 40, so the totem life calculation used level 40 monster life instead of the skill's own exported actor level.
Fix
getTotemLevelhelper beside the existing totem base-skill resolution.actorLevelfrom the totem granted effect/stat set when present.data.minionLevelTablebehavior as the fallback for totem sources without exported actor levels.monsterAllyLifeTable[98].Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S 'Shockwave Totem actor level totem life' --json number,title,headRefName,author,url --jq '.'->[]gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '261 Shockwave Totem' --json number,title,headRefName,author,url --jq '.'->[]git diff --check-> passed (Git emitted only local CRLF conversion warnings)git diff --cached --check-> passed (Git emitted only local CRLF conversion warnings)git show --check --oneline --no-renames HEAD-> passedGet-Command lua,luajit,busted,docker,docker-compose-> not found on this Windows PATH, so I could not execute the Busted suite locally here.Risk / Rollback
Risk is limited to totem level/life calculations. Totems that do not export actor levels keep the previous minion-level fallback. Rollback is the single commit on this branch.