Apply bow additional arrows to bow attacks#1914
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
user issue so this PR does not apply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #783.
Makes
Bow Attacks fire an additional Arrow/Bow Attacks fire 2 additional Arrowsapply to bow attacks' projectile count.This intentionally does not multiply normal displayed hit DPS by arrow count. It only fixes the objective parser/matching issue that prevented the projectile-count modifier from matching current PoE2 bow skill flags.
Root Cause
The parser mapped
Bow Attacks fire ... additional ArrowstoKeywordFlag.Arrow. Current bow attacks such as Lightning Arrow receiveModFlag.Bow/ bow weapon matching, but do not appear to setskillFlags.arrow, so these mods were filtered out beforeProjectileCountwas summed.Fix
ModFlag.Bow.Validation
Local, non-GUI validation only:
I did not run Busted locally because this Windows checkout does not have Lua/LuaJIT/Busted on PATH. I also avoided Docker/GUI validation so no visible command windows or heavy processes were launched.
Risk / Rollback
Low risk. The change is limited to parser entries that explicitly say "Bow Attacks" and narrows matching to bow attacks via the existing
ModFlag.Bowpath. Rollback is this single commit.