List desecrated mods in Add Modifier#1913
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Already handled by this PR #1773 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1772.
Adds Desecrated as an Add Modifier source for item bases that can actually spawn those modifiers, so Kurgal/Abyss desecrated mods that already parse from pasted/imported items can also be selected manually from the Craft -> Add Modifier popup.
Root Cause
ItemsTabClass:AddCustomModifierToDisplayItem()only built source lists for normal prefixes/suffixes, essences, and freeform custom text. Desecrated modifiers were loaded indata.itemMods.Desecratedand pasted/imported items already preserved{desecrated}lines, but the Add Modifier popup never exposed that data source.Fix
ItemsTabClass:BuildAddModifierList(sourceId)so it can be regression-tested without opening UI.DESECRATEDsource that iteratesdata.itemMods.Desecratedand reuses the existing item spawn-weight filter.desecrated = true, preserving the existing raw item round-trip behaviour.Validation
Local, non-GUI validation only:
I did not run Busted locally because this Windows checkout does not have Lua/LuaJIT/Busted on PATH. I also avoided Docker/GUI validation so no visible command windows or heavy processes were launched.
Risk / Rollback
Low risk. This only adds a new Add Modifier source using already-loaded desecrated mod data and existing spawn-weight filtering. If needed, rollback is just this commit; pasted/imported desecrated item parsing remains unchanged.