Parse Breach Ring catalyst quality from game copies#1910
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Does not correctly affect mods to make them scale back to their base value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #558
Summary
Quality (Attack Modifiers): +50% (augmented).Root Cause
The item parser only treated simple
Name: valuespecial lines as metadata. Game-copied catalyst quality usesQuality (<modifier family>): +N% (augmented), so it was not recognized as quality metadata and the item lost the Breach Ring catalyst quality display.Fix
Added a small catalyst-quality label map and a parser for the game-copied quality line before generic mod parsing. The parsed line is metadata-only: it sets
item.catalystanditem.catalystQuality, then skips normal modifier parsing so already-augmented copied affix values are not scaled again.Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '558 Breach Rings quality catalyst import' --json number,title,headRefName,author,url --jq '.'returned[].git diff --checkpassed.git diff --cached --checkpassed.git show --check --stat --oneline HEADpassed.spec/System/TestItemParse_spec.luausing the copied Breach Ring text from the issue. It asserts the attack catalyst and 50 quality are parsed while the attack damage line keepsvalueScalar == 1.I did not run the containerized Busted suite locally; this machine is currently being kept free of extra containers/windows. The included spec covers the reported import format and the double-scaling guard.
Risk / Rollback
Low to moderate risk. The parser is narrow and only handles
Quality (...)catalyst lines with(augmented). Rollback is the single commit on this branch.