Mark Black Doubt sacrifice mod unscalable#1909
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Does not fix the underlying issue with why that mod is working incorrectly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113
Summary
applyRangeregression proving value scaling/catalyst scaling leaves the sacrifice percentage unchanged.Root Cause
The generated scalability table marked
Sacrifice #% of Life to gain that much Energy Shield when you Cast a Spellas scalable. That allows generic value scaling to change the sacrifice percentage, even though the in-game modifier is unscalable.Fix
Changed only that exact scalability entry to
isScalable = false. Nearby sacrifice modifiers remain untouched.Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '113 Black Doubt sacrifice scalable' --json number,title,headRefName,author,url --jq '.'returned[].git diff --checkpassed.git diff --cached --checkpassed.git show --check --stat --oneline HEADpassed.itemLib.applyRangeregression inspec/System/TestItemTools_spec.luafor the exact Black Doubt sacrifice line.I did not run the containerized Busted suite locally; this machine is currently being kept free of extra containers/windows. The included spec targets the exact scalability behavior.
Risk / Rollback
Low risk. The patch touches one exact data row and one focused regression. Rollback is the single commit on this branch.