Skip to content

Mark Black Doubt sacrifice mod unscalable#1909

Closed
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/black-doubt-sacrifice-unscalable
Closed

Mark Black Doubt sacrifice mod unscalable#1909
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/black-doubt-sacrifice-unscalable

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Fixes #113

Summary

  • Mark The Black Doubt's sacrifice percentage as unscalable in mod scalability data.
  • Add an applyRange regression proving value scaling/catalyst scaling leaves the sacrifice percentage unchanged.

Root Cause

The generated scalability table marked Sacrifice #% of Life to gain that much Energy Shield when you Cast a Spell as scalable. That allows generic value scaling to change the sacrifice percentage, even though the in-game modifier is unscalable.

Fix

Changed only that exact scalability entry to isScalable = false. Nearby sacrifice modifiers remain untouched.

Validation

  • gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '113 Black Doubt sacrifice scalable' --json number,title,headRefName,author,url --jq '.' returned [].
  • git diff --check passed.
  • git diff --cached --check passed.
  • git show --check --stat --oneline HEAD passed.
  • Added an itemLib.applyRange regression in spec/System/TestItemTools_spec.lua for the exact Black Doubt sacrifice line.

I did not run the containerized Busted suite locally; this machine is currently being kept free of extra containers/windows. The included spec targets the exact scalability behavior.

Risk / Rollback

Low risk. The patch touches one exact data row and one focused regression. Rollback is the single commit on this branch.

@LocalIdentity
Copy link
Copy Markdown
Contributor

Does not fix the underlying issue with why that mod is working incorrectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Black Doubt's sacrfice mod should be unscalable

2 participants