Fix disconnected radius attribute passives granting stats#1907
Closed
unrealdreamz wants to merge 1 commit into
Closed
Fix disconnected radius attribute passives granting stats#1907unrealdreamz wants to merge 1 commit into
unrealdreamz wants to merge 1 commit into
Conversation
Contributor
|
Bug with the game and not PoB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Nodes affected by "can be Allocated without being connected" radius effects are marked through
intuitiveLeapLikesAffecting, butbuildModListForNodestill always added the node's basemodList. For attribute passives, that meant PoB granted Str/Dex/Int even when the node was allocated only through the disconnected-radius mechanic, which does not currently grant those attributes in-game.Fix
When a node is an attribute passive, is affected by a disconnected-allocation radius, and is not connected to the class start, its base attribute mod list is skipped. Connected attribute passives remain unchanged.
Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '241' --json number,title,headRefName,author,url --jq '.'→[]gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '"From Nothing"' --json number,title,headRefName,author,url --jq '.'→ existing From Nothing/radius PRs, none for this attribute-stat behaviorgit diff --check→ pass (CRLF warning only)git diff --cached --check→ pass (CRLF warning only)git show --check --stat --oneline HEAD→ passI did not run the containerized Busted suite locally; this machine is currently being kept free of extra containers/windows. The included spec exercises the changed passive-node modifier branch directly.
Risk / Rollback
Risk is limited to attribute passives allocated only by disconnected-radius mechanics. If GGG fixes the in-game behavior later, this can be reverted cleanly.
Fixes #241