Skip to content

Fix disconnected radius attribute passives granting stats#1907

Closed
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/from-nothing-attribute-passives
Closed

Fix disconnected radius attribute passives granting stats#1907
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/from-nothing-attribute-passives

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Summary

  • Stop disconnected radius-allocated attribute passives from granting their Str/Dex/Int stats.
  • Preserve normal connected attribute passives, even if they are also inside an Intuitive Leap / From Nothing style radius.
  • Add a regression around the passive-node modifier path.

Root Cause

Nodes affected by "can be Allocated without being connected" radius effects are marked through intuitiveLeapLikesAffecting, but buildModListForNode still always added the node's base modList. For attribute passives, that meant PoB granted Str/Dex/Int even when the node was allocated only through the disconnected-radius mechanic, which does not currently grant those attributes in-game.

Fix

When a node is an attribute passive, is affected by a disconnected-allocation radius, and is not connected to the class start, its base attribute mod list is skipped. Connected attribute passives remain unchanged.

Validation

  • gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '241' --json number,title,headRefName,author,url --jq '.'[]
  • gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '"From Nothing"' --json number,title,headRefName,author,url --jq '.' → existing From Nothing/radius PRs, none for this attribute-stat behavior
  • git diff --check → pass (CRLF warning only)
  • git diff --cached --check → pass (CRLF warning only)
  • git show --check --stat --oneline HEAD → pass

I did not run the containerized Busted suite locally; this machine is currently being kept free of extra containers/windows. The included spec exercises the changed passive-node modifier branch directly.

Risk / Rollback

Risk is limited to attribute passives allocated only by disconnected-radius mechanics. If GGG fixes the in-game behavior later, this can be reverted cleanly.

Fixes #241

@LocalIdentity
Copy link
Copy Markdown
Contributor

Bug with the game and not PoB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute nodes that can be freely allocated should not give attribute bonuses

2 participants