Skip to content

Fix Inhibitor charge consumption benefits#1905

Closed
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/inhibitor-charge-consumption-benefits
Closed

Fix Inhibitor charge consumption benefits#1905
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/inhibitor-charge-consumption-benefits

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Summary

Make CannotConsumeCharges suppress charge-consumption benefits, fixing Inhibitor + Barrage repeat scaling from Frenzy charges.

Fixes #1036

Root Cause

Inhibitor correctly adds SkillType.CannotConsumeCharges to supported skills, but charge-consumption benefit mods are still emitted when the supported skill is built. For Barrage, the global Barrage buff keeps a BarrageRepeats modifier scaled by RemovableFrenzyCharge, so Lightning Spear still receives extra Barrage repeats even though Inhibitor prevents Barrage from consuming charges in game.

Fix

  • Added a small helper that identifies mods scaled by removable Power/Frenzy/Endurance/total charge multipliers.
  • During active skill mod-list construction, remove those charge-consumption benefit mods when the active skill has SkillType.CannotConsumeCharges.
  • Kept ordinary charge-count benefits intact, such as Inhibitor's own damage bonus per charge type, because those use FrenzyCharge/PowerCharge/EnduranceCharge, not removable charge multipliers.
  • Added a focused regression proving Barrage keeps its base repeat buff while Inhibitor removes the Frenzy-charge repeat component.

Validation

Local validation run:

git diff --check
PASS (CRLF normalization warnings only)

git diff --cached --check
PASS (CRLF normalization warnings only)

git show --check --stat --oneline HEAD
PASS (CRLF normalization warnings only)

I did not run Docker/Busted locally because the available full test runner is container-based and I was avoiding external test containers/windows during this session.

Risk / Rollback

Risk is limited to skills/support setups that explicitly gain CannotConsumeCharges. The removal predicate is narrow: only removable-charge multiplier/threshold mods are filtered. Ordinary charge-count scaling is left alone. Rollback is the single commit if a supported skill is found where CannotConsumeCharges should still allow a removable-charge benefit.

@LocalIdentity
Copy link
Copy Markdown
Contributor

Fixed by me on dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inhibitor

2 participants