Fix Palm skills not using Quarterstaff Damage and Crit#1903
Merged
LocalIdentity merged 2 commits intoMay 20, 2026
Merged
Conversation
LocalIdentity
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Palm strike skill flags so the 0.3 quarterstaff damage update is reflected in calculations.
Fixes #1684
Root Cause
The generated skill data still marked the affected Palm hit stat sets as
unarmed. That sends the skills through the unarmed calculation path, replacing the equipped quarterstaff withdata.unarmedWeaponData, which explains the reported 5% crit chance and very low damage on Staggering Palm.Official 0.3.0 notes changed Killing Palm, Staggering Palm, Shattering Palm, Hand of Chayula, and Frozen Locus to deal damage based on the equipped quarterstaff. Frozen Locus was already exported as a weapon attack, but the Palm strike skills still had stale unarmed flags.
Fix
unarmedflags from Hand of Chayula, Killing Palm, Shattering Palm, and Staggering Palm hit stat sets.meleeflag to Staggering Palm's hit stat set.Validation
Local validation run:
I did not run Docker/Busted locally because the available full test runner is container-based and I was avoiding external test containers/windows during this session.
Risk / Rollback
Risk is limited to the affected Palm hit stat-set flags. This avoids changing shared unarmed or weapon calculation logic. Rollback is the single commit if exported game data later says these skills should regain unarmed-only behavior.