Fix Undying Hate attribute passive bonuses not working#1902
Merged
LocalIdentity merged 1 commit intoMay 20, 2026
Merged
Conversation
LocalIdentity
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Timeless Jewel radius handling so conquered attribute passives can receive attribute-node bonuses such as Undying Hate's
Conquered Attribute Passive Skills also grant +7 to Strength.Fixes #1509
Root Cause
ModParseralready parses the conquered attribute passive line, including thenode.isAttributecase. The Timeless/Time-Lost fast path inCalcSetup.buildModListForNode, however, cached only small non-attribute and notable node outputs, then skipped attribute nodes entirely. As a result the parsed Undying Hate modifier never reached allocated attribute passives.Fix
Normalattribute nodes.buildModListForNodeproving attribute and non-attribute cached outputs stay separated.Validation
Local validation run:
I did not run Docker/Busted locally because the available test runner is container-based and I was avoiding external test containers/windows during this session.
Risk / Rollback
Risk is low and localized to the Timeless/Time-Lost radius-jewel cache. The change adds a third cached node shape instead of changing parser semantics or normal radius-jewel execution. Rollback is the single commit if any unexpected Timeless Jewel cache behavior appears.