Skip to content

Fix Undying Hate attribute passive bonuses not working#1902

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/undying-hate-attribute-passives
May 20, 2026
Merged

Fix Undying Hate attribute passive bonuses not working#1902
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/undying-hate-attribute-passives

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Summary

Fixes Timeless Jewel radius handling so conquered attribute passives can receive attribute-node bonuses such as Undying Hate's Conquered Attribute Passive Skills also grant +7 to Strength.

Fixes #1509

Root Cause

ModParser already parses the conquered attribute passive line, including the node.isAttribute case. The Timeless/Time-Lost fast path in CalcSetup.buildModListForNode, however, cached only small non-attribute and notable node outputs, then skipped attribute nodes entirely. As a result the parsed Undying Hate modifier never reached allocated attribute passives.

Fix

  • Added a cached attribute-node pass alongside the existing small and notable Timeless Jewel cache entries.
  • Allowed the Timeless/Time-Lost radius path to use that cache for Normal attribute nodes.
  • Kept existing small-passive and notable behavior unchanged.
  • Added a focused regression around buildModListForNode proving attribute and non-attribute cached outputs stay separated.

Validation

Local validation run:

git diff --check
PASS (CRLF normalization warnings only)

git diff --cached --check
PASS (CRLF normalization warnings only)

git show --check --stat --oneline HEAD
PASS (CRLF normalization warnings only)

I did not run Docker/Busted locally because the available test runner is container-based and I was avoiding external test containers/windows during this session.

Risk / Rollback

Risk is low and localized to the Timeless/Time-Lost radius-jewel cache. The change adds a third cached node shape instead of changing parser semantics or normal radius-jewel execution. Rollback is the single commit if any unexpected Timeless Jewel cache behavior appears.

@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label May 20, 2026
@LocalIdentity LocalIdentity changed the title Fix Undying Hate attribute passive bonuses Fix Undying Hate attribute passive bonuses not working May 20, 2026
@LocalIdentity LocalIdentity merged commit 89772eb into PathOfBuildingCommunity:dev May 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undying Hate not granting stats to attibute nodes

2 participants