Fix Stomping Ground and Ferocious Roar not working when using a Talisman#1901
Merged
LocalIdentity merged 3 commits intoMay 20, 2026
Merged
Conversation
The weapon type checks should never have been on the supports in the first place
LocalIdentity
approved these changes
May 20, 2026
Contributor
LocalIdentity
left a comment
There was a problem hiding this comment.
Simplified the fix by removing the weapon type export for support gems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1676.
Prevents Stomping Ground's support-granted shockwave weapon metadata from making the supported Rampage skill fail its talisman weapon check.
Root Cause
CalcActiveSkillmerged weapon requirements from every compatible support into the active skill's weapon check. Stomping Ground is a support gem that grants its own triggered shockwave skill, and its exportedweaponTypesmetadata belongs to that granted effect. Applying that support metadata to Rampage made Rampage require both a talisman and a two-handed mace, so the skill was disabled as an invalid weapon setup.Fix
weaponTypesas an active-skill requirement when that support gem also grants an active skill.Validation
git diff --check— passed, CRLF conversion warnings only.git diff --cached --check— passed, CRLF conversion warnings only.git show --check --stat --oneline HEAD— passed.I did not run Docker/Busted locally on this machine; the local test path for this repo is container-based and I avoided starting containers or external windows during this contribution pass.
Risk / Rollback
Risk is limited to weapon-type validation for support gems that grant their own active skill. Stomping Ground is currently the only support in the exported support data with both
support = trueandweaponTypes, so the blast radius is intentionally small. Rollback is the single commit if maintainers prefer a data-side exception instead.