Skip to content

Fix Stomping Ground and Ferocious Roar not working when using a Talisman#1901

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/stomping-ground-rampage
May 20, 2026
Merged

Fix Stomping Ground and Ferocious Roar not working when using a Talisman#1901
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/stomping-ground-rampage

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Summary

Fixes #1676.

Prevents Stomping Ground's support-granted shockwave weapon metadata from making the supported Rampage skill fail its talisman weapon check.

Root Cause

CalcActiveSkill merged weapon requirements from every compatible support into the active skill's weapon check. Stomping Ground is a support gem that grants its own triggered shockwave skill, and its exported weaponTypes metadata belongs to that granted effect. Applying that support metadata to Rampage made Rampage require both a talisman and a two-handed mace, so the skill was disabled as an invalid weapon setup.

Fix

  • Keep the active skill's own weapon requirements unchanged.
  • Continue respecting support weapon requirements for ordinary supports.
  • Do not apply a support gem's weaponTypes as an active-skill requirement when that support gem also grants an active skill.
  • Add a regression with Rampage + Stomping Ground on a Changeling Talisman, asserting Rampage remains enabled.

Validation

  • git diff --check — passed, CRLF conversion warnings only.
  • git diff --cached --check — passed, CRLF conversion warnings only.
  • git show --check --stat --oneline HEAD — passed.

I did not run Docker/Busted locally on this machine; the local test path for this repo is container-based and I avoided starting containers or external windows during this contribution pass.

Risk / Rollback

Risk is limited to weapon-type validation for support gems that grant their own active skill. Stomping Ground is currently the only support in the exported support data with both support = true and weaponTypes, so the blast radius is intentionally small. Rollback is the single commit if maintainers prefer a data-side exception instead.

unrealdreamz and others added 3 commits May 18, 2026 18:13
The weapon type checks should never have been on the supports in the first place
Copy link
Copy Markdown
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified the fix by removing the weapon type export for support gems

@LocalIdentity LocalIdentity changed the title Fix Stomping Ground Rampage weapon check Fix Stomping Ground and Ferocious Roar not working properly May 20, 2026
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label May 20, 2026
@LocalIdentity LocalIdentity changed the title Fix Stomping Ground and Ferocious Roar not working properly Fix Stomping Ground and Ferocious Roar not working when using a Talisman May 20, 2026
@LocalIdentity LocalIdentity merged commit d5f5fbd into PathOfBuildingCommunity:dev May 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rampage calculations are disabled "incorrect weapon type" while Stomping Ground gem is toggled on.

2 participants