Fix applyRange plus sign at zero#1888
Open
unrealdreamz wants to merge 1 commit into
Open
Conversation
LocalIdentity
requested changes
May 20, 2026
Contributor
LocalIdentity
left a comment
There was a problem hiding this comment.
Does not work, currently just hides the slider now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1412
Summary
+when ranged item text resolves exactly to zero.applyRangeregression for a signed range centered on zero.Root Cause
itemLib.applyRangepreserved the original plus sign when the interpolated range value was>= 0. That produced+0 ...for ranges that land exactly on zero, even though the rest of item text formatting uses plain0.Fix
Preserve
+only for strictly positive interpolated values. Negative values already drop the plus sign, and now zero does too.Validation
git diff --check- pass, exit code 0.spec/System/TestItemTools_spec.lua.Risk/Rollback
Very low risk: the change is limited to signed range formatting when an originally plus-prefixed range resolves to exactly zero.