Fix Ember Fusillade projectile DPS#1876
Open
unrealdreamz wants to merge 1 commit into
Open
Conversation
LocalIdentity
requested changes
May 20, 2026
Contributor
LocalIdentity
left a comment
There was a problem hiding this comment.
Ember fusillade requires the proper calcs just like we have for poB 1
PathOfBuildingCommunity/PathOfBuilding#9362
PathOfBuildingCommunity/PathOfBuilding#9443
PathOfBuildingCommunity/PathOfBuilding#9452
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Fix
preDamageFuncthat maps the already-calculatedoutput.ProjectileCountintoskillData.dpsMultiplier.Validation
git diff --checklupa:src/Data/Skills/act_int.lua: syntax okspec/System/TestSkills_spec.lua: syntax okbusted --lua=luajit ../spec/System/TestSkills_spec.lua11 successes / 0 failures / 0 errors / 0 pending : 67.641 secondsdocker-compose upGenerated data note
src/Export/Skills/act_int.txtis the source template change.src/Data/Skills/act_int.luais the matching generated data update included for review/runtime consistency.Risk / Rollback
Fixes #1850