Remove unnecessary echo from esc_html_e() in settings-page.php

[DAnn2012]

Description

This pull request simplifies the heading output by removing the unnecessary echo statement around esc_html_e().

Motivation and context

The esc_html_e() function in WordPress already echoes the escaped and translated string. Wrapping it in echo is redundant and can lead to unexpected behavior, such as duplicated output or warnings in strict coding environments. This change improves code clarity and adheres to WordPress best practices for localization and output.

How has this been tested?

• Verified that the heading renders correctly in the WordPress admin interface.
• Confirmed that no duplicate output or PHP warnings occur.
• Checked that the translation domain 'wp-parsely' loads the correct localized string.

Summary by CodeRabbit

• Bug Fixes
  • Fixed duplicate output of the settings page heading.

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed a redundant echo statement before esc_html_e() in the settings page H1 element. The function esc_html_e() already performs output internally, so the explicit echo was redundant and caused incorrect behavior.

Changes

Cohort / File(s)	Summary
Settings page header output src/UI/settings-page.php	Removed redundant echo before esc_html_e() call for H1 heading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "Remove unnecessary echo from esc_html_e() in settings-page.php" directly and accurately describes the main change in the changeset. The title is concise, uses clear language without vague terms or noise, and is specific enough to convey exactly what was modified—the removal of an unnecessary echo statement before the esc_html_e() function call in the settings-page.php file. A teammate scanning the project history would immediately understand this is a bug fix for a double-echo issue without needing to review the full changeset.
Description Check	✅ Passed	The pull request description is comprehensive and well-structured according to the provided template. The Description section clearly articulates the change—removing an unnecessary echo statement around esc_html_e(). The Motivation and Context section provides a solid explanation of why this change is needed, explaining that esc_html_e() already performs the echo and that the redundant echo can cause issues. The How has this been tested section includes specific testing details covering WordPress admin interface verification, output validation, and translation domain confirmation. The Screenshots section is appropriately omitted since this is a code logic change rather than a visual UI modification. All required information sections are present and substantive.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[DAnn2012]

Hello @acicovic

When you can, could you take a look at this PR of mine?

Thanks.

[acicovic]

Hi @DAnn2012,

The project is currently in maintenance mode for the near future and until this changes there will be only dependency updates and no PR reviews.

So I'll take a look at this when more time can be allocated.