Better ASV Pixi integration#47
Merged
Merged
Conversation
Contributor
Author
|
(most of the diff is from the lockfile, which changed significantly because we chance how we install Parcels here) |
python=same was not resolving to the right Python environment on the HPC system (instead resolving to a broken python binary path). Something must be broken in the behaviour when setting python=same
This reverts commit 16095a6. Trying it now, apparently its not a problem? idk anymore
For some reason the platform is acting up with the xgcm python build dep
Member
|
Yep, this new Pixi workflow seems to work for me! Very nice that I can link to another Parcels pro this way. So do we still need the submodule here? |
Member
There was a problem hiding this comment.
Do we need the Parcels submodule, or ask users to link to their local Parcels repo by default?
Contributor
Author
There was a problem hiding this comment.
I think having the Parcels submodule is best - but users can definitely override this locally if they want to for debugging. They can even directly modify the submodule and contribute back that way if they want to
erikvansebille
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this PR results in better Pixi/ASV integration - where ASV (when providing
asv run --python=same) uses the same Pixi installation as in benchmarks pixi environment.If you want to use a different Parcels installation to run the benchmarks, it should be a simple one line update in
pixi.tomlfromThis workflow is working well for me. Feel free to give it a spin @erikvansebille and if it works well for you, we can merge into
main. This can also wait until you're back from EGU.