Add permissions for "reset" and sequence arguments in "/random". - #14128
Open
Mickey42302 wants to merge 3 commits into
Open
Add permissions for "reset" and sequence arguments in "/random".#14128Mickey42302 wants to merge 3 commits into
Mickey42302 wants to merge 3 commits into
Conversation
lynxplay
requested changes
Aug 2, 2026
| .then( | ||
| Commands.literal("reset") | ||
| - .requires(Commands.hasPermission(Commands.LEVEL_GAMEMASTERS)) | ||
| + .requires(stack -> stack.getSender().isOp() || stack.getSender().hasPermission("minecraft.command.random.reset")) // Paper - Add permission node for reset |
Contributor
There was a problem hiding this comment.
Why are we falling to isOp here?
.requires(Commands.<CommandSourceStack>hasPermission(Commands.LEVEL_GAMEMASTERS).or(stack -> stack.getBukkitSender().hasPermission("minecraft.commands.random.reset"))) // Paper - specific permissions for sub command would work.
| Commands.argument("sequence", IdentifierArgument.id()) | ||
| .suggests(RandomCommand::suggestRandomSequence) | ||
| - .requires(Commands.hasPermission(Commands.LEVEL_GAMEMASTERS)) | ||
| + .requires(stack -> stack.getSender().isOp() || stack.getSender().hasPermission("minecraft.command.random.sequence")) // Paper - Add permission node for sequence |
Contributor
There was a problem hiding this comment.
This one permission covers both the /random value and /random roll command.
Shouldn't this be split up?
github-project-automation
Bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
Contributor
Author
|
The code is updated now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to suggest implementing some additional permission nodes for "/random".
Currently, the "reset" subcommand and sequence arguments only work if a player has operator privileges. This is the case even if a regular player has the "minecraft.command.random" permission.
This addition would allow server owners to grant the ability to use sequences and the "reset" subcommand without needing to grant operator privileges.
For the "reset" subcommand, the permission node is "minecraft.command.random.reset". For sequence arguments, the permission node is "minecraft.command.random.sequence".