Skip to content

feat: improve laravel macro rename and references#242

Merged
calebdw merged 1 commit into
mainfrom
calebdw/push-ynqwrmkxlmko
Jul 17, 2026
Merged

feat: improve laravel macro rename and references#242
calebdw merged 1 commit into
mainfrom
calebdw/push-ynqwrmkxlmko

Conversation

@calebdw

@calebdw calebdw commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Treat Laravel macro registration strings as first-class rename and reference targets so edits propagate between ::macro('name', ...) and matching call sites, including collection-style fluent chains. Land macro go-to-definition on the macro name itself, index member-access names for cheaper workspace scans, and warm workspace symbol maps in the background so repeated rename and reference requests avoid reparsing unopened files.

@calebdw
calebdw force-pushed the calebdw/push-ynqwrmkxlmko branch from 4317d55 to ba7d28a Compare July 17, 2026 15:23
Treat Laravel macro registration strings as first-class rename and
reference targets so edits propagate between ::macro('name', ...)
and matching call sites, including collection-style fluent chains.
Land macro go-to-definition on the macro name itself, index
member-access names for cheaper workspace scans, and warm workspace
symbol maps in the background so repeated rename and reference
requests avoid reparsing unopened files.
@calebdw
calebdw force-pushed the calebdw/push-ynqwrmkxlmko branch from ba7d28a to 35797b5 Compare July 17, 2026 15:43
@calebdw
calebdw merged commit e7172f5 into main Jul 17, 2026
7 checks passed
@calebdw
calebdw deleted the calebdw/push-ynqwrmkxlmko branch July 17, 2026 15:54
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 92.35294% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/references/mod.rs 93.30% 16 Missing ⚠️
src/symbol_map/extraction.rs 92.00% 4 Missing ⚠️
src/definition/resolve.rs 0.00% 3 Missing ⚠️
src/rename/mod.rs 0.00% 1 Missing ⚠️
src/semantic_tokens.rs 0.00% 1 Missing ⚠️
src/virtual_members/laravel/macros.rs 97.43% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants