fix: correct schema docs output path in PR preview workflow - #756
Merged
John McCall (lowlydba) merged 1 commit intoSep 21, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow path matches the docs repository’s schema plugin layout; only the PR description’s companion-issue wording needs correction.
Review effort: Lite
Findings: 1
What changed in this PR
Updates the schema PR preview workflow to generate docs into the relocated Docusaurus schema instance.
Changes:
- Changes output path from
_docs/docs/schema/referenceto_docs/schema/reference.
| File | Description |
|---|---|
.github/workflows/schema-pr-preview.yml |
Corrects schema documentation output location. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Dana Bauer (danabauer)
approved these changes
Sep 21, 2026
John McCall (lowlydba)
requested a review
from Alex Iannicelli (atiannicelli)
September 21, 2026 17:39
Alex Iannicelli (atiannicelli)
approved these changes
Sep 21, 2026
John McCall (lowlydba)
deleted the
lowlydba-fix-schema-pr-preview-docs-path
branch
September 21, 2026 17:56
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Generate schema markdown docsstep in.github/workflows/schema-pr-preview.ymlstill writes todocs/schema/reference, a path that predates the docs repo's schema docs instance move. OvertureMaps/docs#512 introduced a dedicated Docusaurus plugin instance for schema docs (idschema, pathschema/,routeBasePathschema), so the generated markdown now needs to land atschema/referenceinstead.This PR updates the
output-dirto${{ github.workspace }}/${{ env.DOCS_PATH }}/schema/reference, matching that new layout.Fixes #755.