[BUG](ci) Install uv before publish-legacy/publish-mcd steps - #742
Merged
John McCall (lowlydba) merged 2 commits intoSep 11, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
John McCall (lowlydba)
had a problem deploying
to
staging
September 11, 2026 14:31 — with
GitHub Actions
Error
John McCall (lowlydba)
marked this pull request as ready for review
September 11, 2026 14:32
John McCall (lowlydba)
requested review from
Alex Iannicelli (atiannicelli) and
Seth Fitzsimmons (sethfitz)
September 11, 2026 14:33
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both publish jobs now install uv before publishing.
Pull request overview
Adds uv installation to both CodeArtifact publish jobs so they work on fresh runners.
Changes:
- Adds pinned
setup-uvtopublish-legacy. - Adds pinned
setup-uvtopublish-mcd.
File summaries
| File | Description |
|---|---|
.github/workflows/main-publish.yaml |
Ensures uv is available before both publish actions run. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Seth Fitzsimmons (sethfitz)
approved these changes
Sep 11, 2026
Alex Iannicelli (atiannicelli)
approved these changes
Sep 11, 2026
John McCall (lowlydba)
deleted the
lowlydba-fix-main-publish-missing-uv
branch
September 11, 2026 15:06
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both publish jobs call
uv-publish-to-codeartifact, which requiresuvalready onPATH(its own comment says so). Neither job installs it, since they run on a fresh runner separate frombuild, so every push tomainsince the dual-publish merge (#725) fails withuv: command not found, exit 127:https://github.com/OvertureMaps/schema/actions/runs/34608725611/job/103293782910
The original draft for the uv-publish action did self-install
uv, but later it was changed to allow consumers greater flexibility / avoid double-install attempts. This more closely follows the ecosystem of GHA where many are single-responsibility and chained together, instead of performing multiple functions.Added the same
astral-sh/setup-uvstepbuildalready uses to bothpublish-legacyandpublish-mcd.Fixes #743
Testing
Not covered by CI: the composite action's
uvrequirement only surfaces on a real push tomain, this workflow doesn't run on PRs. Verifying via a push tomainafter merge.