Repository navigation
docs(base): note that physical water features overlap ocean tiles - #580
Merged
Alex Iannicelli (atiannicelli) merged 1 commit intoOct 17, 2026
Merged
Alex Iannicelli (atiannicelli) merged 1 commit into
Alex Iannicelli (atiannicelli) merged 1 commit into
Conversation
Fixes #579 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alex Iannicelli <atiannicelli@gmail.com>
🗺️ Overture Docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
Alex Iannicelli (atiannicelli)
marked this pull request as ready for review
October 15, 2026 19:19
Alex Iannicelli (atiannicelli)
requested a review
from a team
as a code owner
October 15, 2026 19:19
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused documentation change addresses the issue, with no unresolved findings.
0 open findings
What changed in this PR
Clarifies overlapping water features in the Base guide, addressing #579.
Changes:
- Explains that physical water features overlap ocean and inland water polygons by design.
- Recommends using them for labels and excluding them from fills and area calculations.
- Links to the water schema reference.
| File | Description |
|---|---|
| docs/guides/base/index.mdx | Adds overlap guidance and filtering advice to the Water section. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alex Iannicelli (atiannicelli)
requested a review
from Steve Moore - Esri (skmoore)
October 15, 2026 19:22
Alex Iannicelli (atiannicelli)
deleted the
atiannicelli-base-guide-water-overlap-note
branch
October 17, 2026 15:26
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Adds a note to the Water section of the Base guide: physical water features (
subtype = "physical") overlap ocean and inland water polygons by design, so use them for labels and filter them out for fills or area calculations.Fixes #579
Validation
npm test: passed (177 passed, 7 skipped)npm run build: passed; note renders and links to/schema/reference/base/water/npx markdownlint -c .github/linters/.markdown-lint.yml docs/guides/base/index.mdx: no new errors (same 19 pre-existing errors asmain)