Skip to content

[TASK] Correct the .gitignore comment for schema/reference/ after the schema docs move #519

Description

@danabauer

Type

Task

Scope

Multi-theme or Platform

Skillset

engineering

Description

What

.gitignore lines 7-9 read:

# Scratch output of the schema doc generator: written by add-schema-version and
# by the schema repo's PR preview workflow (SCHEMA_PREVIEW=true). See README.
schema/reference/

The path and the entry are correct and should stay. The second half of the comment is not currently true.

Why the entry stays

schema/reference/ is read by exactly one thing: a SCHEMA_PREVIEW=true build, where the schema docs instance builds current from schema/ (docusaurus.config.js lines 55-59) and sidebars-schema.js line 10 autogenerates from dirName: 'reference'. Verified on a clean checkout at fccbbe22:

  • npm run build — succeeds, never creates schema/reference/
  • SCHEMA_PREVIEW=true npm run docusaurus -- build — fails on broken links to /schema/reference/* when the directory is absent

That generated tree is a rolling build of an unreleased schema branch, so it must not be committed next to the released snapshots in schema_versioned_docs/. scripts/add-schema-version.mjs also writes there, and cleans up in a finally (lines 110-112), so it only leaves debris if the run is interrupted.

What is wrong

The schema repo's PR preview workflow does not write to schema/reference/ today. It still writes to docs/schema/reference — the path used before #512 moved the schema instance out of docs/. Filed as OvertureMaps/schema#755.

Worth noting for whoever fixes that: schema/reference/ is root-anchored, so it does not match docs/schema/reference/. Output at the old path shows up as untracked (?? docs/schema/), confirmed with git check-ignore -v --no-index.

Also stale from the same move: sidebars-schema.js line 2 still describes the instance as "docs/schema and schema_versioned_docs/".

Acceptance criteria

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions